Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria2: fix aria2/aria2#2152 #22956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

aria2: fix aria2/aria2#2152 #22956

wants to merge 1 commit into from

Conversation

Arielfoever
Copy link
Contributor

@Arielfoever Arielfoever commented Dec 22, 2023 •
edited
Loading

fix "Exception: [Platform.cc:125] errorCode=1 OSSL_PROVIDER_load 'legacy' failed." Bug in aria2/aria2#2152

Maintainer: @kaloz@openwrt.org @kuoruan@gmail.com
Compile tested: mediatek/filogic (ARMv8 Processor rev 4) & GL.iNet AXT1800
Run tested: same
Description:

@1715173329
Copy link
Member

  • You should raise PKG_RELEASE
  • Use more descriptive commit title

@Arielfoever
aria2: fix OSSL_PROVIDER_load 'legacy' failed (aria2/aria2#2152)
b8032af 
fix "Exception: [Platform.cc:125] errorCode=1 OSSL_PROVIDER_load 'legacy' failed." Bug

Signed-off-by: Ariel Xiong <ArielHeleneto@outlook.com>
@Arielfoever
Copy link
Contributor Author

  • You should raise PKG_RELEASE

    • Use more descriptive commit title

fixed

BKPepe
BKPepe reviewed Jan 1, 2024
View reviewed changes
net/aria2/files/aria2.init
@@ -341,6 +341,7 @@ aria2_start() {
procd_set_param user "$user"

procd_add_jail "$NAME.$section" log
procd_add_jail_mount "/usr/lib"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was why added now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see aria2/aria2#2152 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I remove the comment and add now

@Arielfoever Arielfoever force-pushed the master branch 2 times, most recently from 8beb538 to b8032af Compare January 13, 2024 09:51
@1715173329
Copy link
Member

I'm getting this error with your patch applied:

Collecting package info: done
tmp/.config-package.in:98254:error: recursive dependency detected!
tmp/.config-package.in:98254:	symbol PACKAGE_aria2 is selected by PACKAGE_luci-app-aria2
tmp/.config-package.in:58947:	symbol PACKAGE_luci-app-aria2 depends on ARIA2_OPENSSL
feeds/packages/net/aria2/Config.in:8:	symbol ARIA2_OPENSSL is part of choice <choice>
feeds/packages/net/aria2/Config.in:4:	choice <choice> contains symbol <choice>
feeds/packages/net/aria2/Config.in:4:	choice <choice> contains symbol PACKAGE_aria2
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

tmp/.config-package.in:52196:error: recursive dependency detected!
tmp/.config-package.in:52196:	symbol PACKAGE_libcurl is selected by PACKAGE_clixon
tmp/.config-package.in:132277:	symbol PACKAGE_clixon depends on PACKAGE_libxml2
tmp/.config-package.in:57759:	symbol PACKAGE_libxml2 is selected by PACKAGE_nginx-ssl
tmp/.config-package.in:118530:	symbol PACKAGE_nginx-ssl is selected by PACKAGE_nginx
tmp/.config-package.in:6744:	symbol PACKAGE_nginx is selected by PACKAGE_ariang-nginx
tmp/.config-package.in:98219:	symbol PACKAGE_ariang-nginx depends on PACKAGE_libopenssl
tmp/.config-package.in:49762:	symbol PACKAGE_libopenssl is selected by PACKAGE_libcurl
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

@Arielfoever
Copy link
Contributor Author

I'm getting this error with your patch applied:

Collecting package info: done
tmp/.config-package.in:98254:error: recursive dependency detected!
tmp/.config-package.in:98254:	symbol PACKAGE_aria2 is selected by PACKAGE_luci-app-aria2
tmp/.config-package.in:58947:	symbol PACKAGE_luci-app-aria2 depends on ARIA2_OPENSSL
feeds/packages/net/aria2/Config.in:8:	symbol ARIA2_OPENSSL is part of choice <choice>
feeds/packages/net/aria2/Config.in:4:	choice <choice> contains symbol <choice>
feeds/packages/net/aria2/Config.in:4:	choice <choice> contains symbol PACKAGE_aria2
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

tmp/.config-package.in:52196:error: recursive dependency detected!
tmp/.config-package.in:52196:	symbol PACKAGE_libcurl is selected by PACKAGE_clixon
tmp/.config-package.in:132277:	symbol PACKAGE_clixon depends on PACKAGE_libxml2
tmp/.config-package.in:57759:	symbol PACKAGE_libxml2 is selected by PACKAGE_nginx-ssl
tmp/.config-package.in:118530:	symbol PACKAGE_nginx-ssl is selected by PACKAGE_nginx
tmp/.config-package.in:6744:	symbol PACKAGE_nginx is selected by PACKAGE_ariang-nginx
tmp/.config-package.in:98219:	symbol PACKAGE_ariang-nginx depends on PACKAGE_libopenssl
tmp/.config-package.in:49762:	symbol PACKAGE_libopenssl is selected by PACKAGE_libcurl
For a resolution refer to Documentation/kbuild/kconfig-language.rst
subsection "Kconfig recursive dependency limitations"

no idea with this but I dont get that

BKPepe
BKPepe reviewed Mar 9, 2024
View reviewed changes
net/aria2/Makefile
@@ -53,7 +53,7 @@ define Package/aria2
SUBMENU:=File Transfer
TITLE:=lightweight download utility
URL:=https://aria2.github.io/
DEPENDS:=+zlib +libstdcpp +ARIA2_OPENSSL:libopenssl +ARIA2_GNUTLS:libgnutls \
DEPENDS:=+zlib +libstdcpp +ARIA2_OPENSSL:libopenssl +ARIA2_OPENSSL:libopenssl-legacy +ARIA2_GNUTLS:libgnutls \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is caused by this.

@1715173329
Copy link
Member

run out of idea to get rid of this recursive dependency hell

@backslashxx
Copy link

works well, thanks for the fix

@zcy85611
Copy link

could anyone help to merge the patch pls? thanks

@1715173329
Copy link
Member

This is problematic and introduce new dependency issue.

@Arielfoever
Copy link
Contributor Author

This is problematic and introduce new dependency issue.

but it needs libopenssl-legacy. If you remove this package it doesn't work.

@backslashxx
Copy link

any updates on this?

@1715173329
Copy link
Member

@neheb Would you mind having a look? The dependency here is a bit tricky.

@backslashxx
Copy link

this works even with apk but it will show that recursive dependency thingy
but yeah if you manage to compile it, its all good! this is what I torrent with.

@Arielfoever
Copy link
Contributor Author

So what should I do them?

@neheb
Copy link
Contributor

neheb commented Nov 18, 2024

I'll look into this sometime soon.

@zcy85611
Copy link

I'll look into this sometime soon.

May I ask have you looked into this? thanks

@neheb
Copy link
Contributor

neheb commented Dec 26, 2024

I managed to get rid of the recursive dependency by doing

--- a/net/ariang/Makefile
+++ b/net/ariang/Makefile
@@ -19,7 +19,7 @@ define Package/ariang/default
   SECTION:=net
   CATEGORY:=Network
   SUBMENU:=Download Manager
-  DEPENDS:=+aria2
+  DEPENDS:=aria2
   TITLE:=AriaNg webui
   URL:=https://ariang.mayswind.net
   PKGARCH:=all

and

--- a/applications/luci-app-aria2/Makefile
+++ b/applications/luci-app-aria2/Makefile
@@ -7,7 +7,7 @@
 include $(TOPDIR)/rules.mk
 
 LUCI_TITLE:=LuCI Support for Aria2
-LUCI_DEPENDS:=+luci-base +aria2
+LUCI_DEPENDS:=+luci-base aria2
 
 PKG_MAINTAINER:=Xingwang Liao <kuoruan@gmail.com>
 PKG_LICENSE:=MIT

I don't know that this is correct.

@backslashxx
Copy link

that works well, thanks

@zcy85611
Copy link

so is it okay to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BKPepe BKPepe BKPepe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Arielfoever @1715173329 @backslashxx @zcy85611 @neheb @BKPepe