-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lantiq: xrx200: switch to the mainline DSA driver #3085
Conversation
Hi,
Next week I can do more tests on BT HH 5A and DWR-966 (xrx330, not yet supported). |
Eventually, swconfig should be removed (kernel config symbols and packages as below):
|
8e33934
to
89231c4
Compare
I'll fix the xrx200 subtarget when doing so I'll also update the subject to "lantiq: xrx200: ..." to make it clear what I'm touching exactly ✔️ done |
89231c4
to
9667363
Compare
9667363
to
8fac354
Compare
I'm sad to see that we duplicated work 😢
interesting, I can reproduce this with iperf3 in a few seconds
I included your patch for this in this PR - many thanks! |
On my HH5a at the moment I can go to the 'br-lan' config in luci and add
Does this still work after conversion to DSA? Can I add (I ask because on the Asus RT-AC85P which already uses DSA, this doesn't seem to be working. I can live with that for the moment, but wouldn't want a regression on my main VDSL router...) |
I haven't tried this myself yet - I'll try to test it on Sunday or next week as I don't have access to my HH5A for the rest of the week |
@xdarklight Bootlog:
Tested on HH5A [1] https://elixir.bootlin.com/linux/v5.4.46/source/net/dsa/dsa2.c#L669 |
Same with iperf. Earlier I tested it as AP and the load was smaller. |
for reference, it seems that this will not work as of yet: but it seems to be a general problem, affecting all targets, not just lantiq |
@olek210 which problem is that preinit script supposed to solve? |
Should not cause a problem -517 means |
My mistake, Driver only print warning. I didn't know it was intentional. |
8fac354
to
73b0a26
Compare
PR update:
|
@@ -50,7 +50,11 @@ CONFIG_MTD_UBI_BLOCK=y | |||
# CONFIG_MTD_UBI_FASTMAP is not set | |||
# CONFIG_MTD_UBI_GLUEBI is not set | |||
CONFIG_MTD_UBI_WL_THRESHOLD=4096 | |||
CONFIG_NET_DSA=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please deactivate CONFIG_SWCONFIG
this is not needed any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IN addition you also have to deatcivte these settings:
# CONFIG_PSB6970_PHY is not set
# CONFIG_RTL8366_SMI is not set
# CONFIG_SWCONFIG is not set
Please also refresh the configuration, this DSA driver also activates PHYLINK.
make kernel_oldconfig CONFIG_TARGET=subtarget
target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/vr9_tplink_tdw89x0.dtsi
Outdated
Show resolved
Hide resolved
target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/vr9_tplink_tdw89x0.dtsi
Outdated
Show resolved
Hide resolved
target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/vr9_tplink_tdw89x0.dtsi
Outdated
Show resolved
Hide resolved
target/linux/lantiq/files-5.4/arch/mips/boot/dts/lantiq/vr9_tplink_tdw89x0.dtsi
Outdated
Show resolved
Hide resolved
PR update based on review comments from @hauke (thank you!):
|
73b0a26
to
c7bfa72
Compare
target/linux/lantiq/xrx200/base-files/lib/preinit/05_set_preinit_iface_lantiq
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,5 @@ | |||
set_preinit_iface() { | |||
ifname=eth0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should also not be needed after this patch:
https://patchwork.ozlabs.org/project/openwrt/list/?series=249780
Could someone please try this.
f88f785
to
89fe331
Compare
today's update includes:
also as a side-note: it seems that @abajk's bugfixes will be included in Linux 5.4.128 and 5.10.46 |
Tested-by: Notupus notpp46@googlemail.com # TD-W9980/DM200/FRITZ 7430 |
Tested-by: Martin Schiller ms@dev.tdt.de # tested on TDT VR2020 |
Tested-by: Daniel Kestrel kestrel1974@t-online.de # tested on Fritzbox 7490 |
Tested-by: @jospezial jospezial@gmx.de # tested on VGV7510KW22 (o2 Box 6431) @xdarklight |
today's update includes:
great, thanks for checking! I don't have any time to work on this pull request on Friday and Saturday so on Sunday I'll rebase it again - then I hope that this can be merged. |
89fe331
to
8b6f6ef
Compare
Typo: Update the existing existing vr9_*.dts{,i} |
This backports a fix from Aleksander Jan Bajkowski to TX hangs with threaded NAPI enabled. So far threaded NAPI is disabled by default but can be enabled with: echo 1 > /sys/class/net/eth0/threaded Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
…iver This backports another fix from Aleksander Jan Bajkowski which is a follow-up to a previous memory corruption fix. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Enable the XRX200 PMAC, GSWIP DSA tag and GSIP DSA drivers in the 5.4 kernel config. Update the existing vr9_*.dts{,i} to use the new Ethernet and switch drivers. Drop the swconfig package from the xrx200 target because swconfig doesn't manage DSA based switches. The new /etc/config/network format for the DSA driver is not compatible with the old (swconfig) based one. Show a message during sysupgrade notifying users about this change and asking them to start with a fresh config (or forcefully update and then migrate the config manually). Failsafe mode can now automatically bring up the first lan interface based on board.json including DSA based setups. Drop 05_set_preinit_iface_lantiq from the xRX200 sub-target as this is not needed anymore. For now we are keeping it for the ase, xway and xway_legacy until there's some confirmation that it can be dropped from there as well. While here, some boards also receive minor fixups: - Use LAN1 as LAN1 (according to a photo this port can also be configured as WAN) on the Buffalo WBMR-300HPD. This makes it easier to read the port mapping because otherwise we would have LAN{2,3,4} and WAN (which was the case for the non-DSA version previously). - vr9_avm_fritz3390.dts: move the "gpio" comment from port 0 and 1 to their corresponding PHYs - vr9_tplink_vr200.dtsi: move the "gpio" comment from port 0 to PHY 0 - vr9_tplink_tdw89x0.dtsi: move the "gpio" comment from port 0 to PHY 0 Acked-by: Aleksander Jan Bajkowski <A.Bajkowski@stud.elka.pw.edu.pl> Tested-by: Notupus <notpp46@googlemail.com> # TD-W9980/DM200/FRITZ 7430 Tested-by: Martin Schiller <ms@dev.tdt.de> # tested on TDT VR2020 Tested-by: Martin Schiller <ms@dev.tdt.de> # tested on TP-Link TD-W8980B Tested-by: Martin Schiller <ms@dev.tdt.de> # tested on ZyXEL P-2812HNU-F1 Tested-by: Daniel Kestrel <kestrel1974@t-online.de> # tested on Fritzbox 7490 Tested-by: Daniel Kestrel <kestrel1974@t-online.de> # tested on Fritzbox 3490 Tested-by: @jospezial <jospezial@gmx.de> # tested on VGV7510KW22 (o2 Box 6431) Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
8b6f6ef
to
91cd894
Compare
thanks, fixed |
Thank you for the patch, I applied it to master. |
@hauke Thanks for merging this. Do you think this change will be Backported to 21.02? |
@ngrsdhbw just FYI that this question was also raised on the mailing list, see: |
-Overlaying board.bin in /lib/firmware/ath10k/QCA988X/hw2.0 should fix the issue that some devices could not bring up ath10k with the wasp image
On my VGV7510KW22 the LAN port where my pc is connected is sometimes hanging after powering off and on the pc. Maybe some bad voltage impulses or ESD. Happens about once in 3 weeks or twice a week. Sporadic. |
Upgraded to master with dsa yesterday, after being on a stable pre dsa for multiple months. First day after Ethernet stops working with following message
|
Enable the XRX200 PMAC, GSWIP DSA tag and GSIP DSA drivers in the 5.4
kernel config. Finally switch existing vr9_*.dts{,i} to use the new
Ethernet and switch drivers.
WiP:
master
branch and update the testing kernel version (5.10) as welllantiq_xrx200.c
driver which may lead to memory corruptionlantiq_xrx200.c