-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ramips: disable hardware NAT offload for MT7621 #1916
Conversation
Turn off the problematic hardware flow offloading on MT7621 The hardware NAT offload driver was introduced in 424a9ae Unfortunately it has issues, including broken IPv6 and kernel panics. Disable it for now. Consider enabling this again after the kernel 4.19 drivers land. Fixes: FS#1763 FS#2157 FS#2158 FS#2115 FS#1956 FS#1917 Signed-off-by: JC Hulce <git@jchulce.com>
Does the driver actually break things if it's not enabled in /etc/config/firewall? |
Yes, IPv6 is broken unless openwrt is recompiled without this driver, see FS#1763 |
I posted a patch for testing in that ticket (to resolve the broken IPv6 case). Could you please try it? |
my test on device GHL without any patch, ipv6 works |
|
My router is newifi-d2 which cpu is MT7621. I did not meet the broken IPv6 problem,but still got some kernel panics. |
Exactly the same thing here on a 860L router (mt7621 as well). It looks like the reason for the crash is resource utilization dependent, and obviously the HW acceleration removes quite some load from the CPU. None the less, it is indeed seems like there is a relation. These types of crashes were present before HW accel was introduced, but it definitely helped on the frequency of it. |
Any update on this issue? |
My router is phicomm k2p with with MTK 4.4.2.1 driver.When I enable Hardware NAT,the router may reboot when load average is high.Atfer turning off it,it becomes stable.Now I just enable Flow Offloading |
Does this d344591 commit resolve this issue? |
@jchulce can you please try to reproduce your issues with latest snapshot images? |
@jchulce It's disabled by default, isn't it? You need to explicitly enable it. |
Still kernel panic if I enabled the hardware flow offload, tested with the latest snapshot
|
report bug log here on my friend MIR3G device:
|
(Sorry, off-topic:) @haswelliris Can you check that? If yes, I would also be interested in which of the two addresses should be "lan" and which "wan" then ... |
@nbd168 @ynezz I have finally had a chance to try latest snapshot SNAPSHOT r10827-c262daf308 on my UBNT-ERX. I can confirm that IPv6 works properly with no offload, software offload, and on hardware offload. I have not tested snapshot enough to determine stability/kernel panics. Going to close this PR, hopefully the stability gets further investigated elsewhere. |
Turn off the problematic hardware flow offloading on MT7621
The hardware NAT offload driver was introduced in
424a9ae
Unfortunately it has issues, including broken IPv6 and kernel panics.
Disable it for now.
Consider enabling this again after the kernel 4.19 drivers land.
Fixes: FS#1763 FS#2157 FS#2158 FS#2115 FS#1956 FS#1917
Signed-off-by: JC Hulce git@jchulce.com
This is my first commit to openwrt, please let me know if I'm doing something wrong.