Added blobs support for Static LLM pipeline #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyaPronina
force-pushed
the
support_blobs_for_llm_pipeline
branch
3 times, most recently
from
c885b82 to
be7066f
Compare
AsyaPronina
force-pushed
the
support_blobs_for_llm_pipeline
branch
from
be7066f to
bf253f7
Compare
AsyaPronina
force-pushed
the
support_blobs_for_llm_pipeline
branch
2 times, most recently
from
cf30b0e to
980eebf
Compare
|
@ilya-lavrenov @Wovchena Could you have a look, please? |
| // (1) Check that neither MAX_PROMPT_LEN nor MIN_RESPONSE_LEN is | ||
| // exposed in the config | ||
| if (pipeline_config.count("MAX_PROMPT_LEN") || | ||
| pipeline_config.count("MIN_RESPONSE_LEN")) { |
There was a problem hiding this comment.
so many hardcoded strings.. how users would know that such strings should be passed?
will it be mentioned in NPU specific docs?
There was a problem hiding this comment.
Yes, I believe these parameters can be reflected in "Additional configuration options": https://docs.openvino.ai/2024/learn-openvino/llm_inference_guide/genai-guide-npu.html
There was a problem hiding this comment.
You refused to do that 2 weeks ago: #795 (review). In personal messages you stated that you don't want to advertise them. What changed?
There was a problem hiding this comment.
Didn't refuse to be honest, these parameters will be documented for 2024.4
ilya-lavrenov
approved these changes
Sep 6, 2024
AsyaPronina
force-pushed
the
support_blobs_for_llm_pipeline
branch
from
980eebf to
bae4b46
Compare
TolyaTalamanov
approved these changes
Sep 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Added support of importing blobs for `StaticLLMPipeline`
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support of importing blobs for
StaticLLMPipeline