StaticLLMPipeline: Introduced NPUW_UNFOLD_IREQ for hint FAST_COMPILE #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmatveev
reviewed
Nov 29, 2024
Comment on lines
254
to
+255
| OPENVINO_THROW("Unsupported \"GENERATE_HINT\" provided: " + | ||
| str + ". Please select either \"FAST_COMPILE\" or \"BEST_PERF\"."); | ||
| str + ". Please select either \"" + to_string(GenerateHint::BEST_PERF) + "\" or \"" + to_string(GenerateHint::FAST_COMPILE) +"\"."); |
There was a problem hiding this comment.
Just in case - if operator<<(ostream&) is provided for the hint type, OPENVINO_THROW concatenates the arguments to a string itself so it could be just
OPENVINO_THROW("Unsupported \"GENERATE_HINT\" provided: ", str, ". Please select either \"", GenerateHint::BEST_PERF, "\" or \"", GenerateHint::FAST_COMPILE, "\".");
| @@ -523,6 +534,9 @@ ov::AnyMap get_default_generate_config(const std::shared_ptr<ov::Model>& model, | |||
| if (npudesc.has_value() && npudesc->arch == "4000") { | |||
| config.emplace("NPU_DPU_GROUPS", 4); | |||
| } | |||
| if (hint == GenerateHint::FAST_COMPILE) { | |||
There was a problem hiding this comment.
Let's check if it doesn't break anything on arch<4000
There was a problem hiding this comment.
Looks there is no regressions on MTL system. While performance(tokens rate) of LLama2 increased at least by 10%
dmatveev
approved these changes
Dec 3, 2024
|
build_jenkins |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
copy of PR : #1275 to release/2024/5
sungeunk
pushed a commit
to sungeunk/openvino.genai
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E-149055