-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StaticLLMPipeline: Decide when to enable NPUW_DQ_FULL property #1258
StaticLLMPipeline: Decide when to enable NPUW_DQ_FULL property #1258
Conversation
src/cpp/CMakeLists.txt
Outdated
@@ -71,7 +71,7 @@ target_include_directories(${TARGET_NAME} | |||
|
|||
target_include_directories(${TARGET_NAME} SYSTEM PRIVATE "${safetensors.h_SOURCE_DIR}") | |||
|
|||
target_link_libraries(${TARGET_NAME} PUBLIC openvino::runtime PRIVATE openvino::threading nlohmann_json::nlohmann_json jinja2cpp) | |||
target_link_libraries(${TARGET_NAME} PUBLIC openvino::runtime openvino::runtime::dev PRIVATE openvino::threading nlohmann_json::nlohmann_json jinja2cpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required for ov::internal::supported_properties
. Is there any better way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it breaks OpenVINO GenAI compilation against public OpenVINO package where Dev part is not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworked
src/cpp/CMakeLists.txt
Outdated
@@ -71,7 +71,7 @@ target_include_directories(${TARGET_NAME} | |||
|
|||
target_include_directories(${TARGET_NAME} SYSTEM PRIVATE "${safetensors.h_SOURCE_DIR}") | |||
|
|||
target_link_libraries(${TARGET_NAME} PUBLIC openvino::runtime PRIVATE openvino::threading nlohmann_json::nlohmann_json jinja2cpp) | |||
target_link_libraries(${TARGET_NAME} PUBLIC openvino::runtime openvino::runtime::dev PRIVATE openvino::threading nlohmann_json::nlohmann_json jinja2cpp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it breaks OpenVINO GenAI compilation against public OpenVINO package where Dev part is not available.
bool compiler_dq = false; | ||
const auto device_caps = core.get_property("NPU", ov::device::capabilities); | ||
if (std::find(device_caps.begin(), device_caps.end(), | ||
"COMPILER_DYNAMIC_QUANTIZATION") != device_caps.end()) { | ||
compiler_dq = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool compiler_dq = false; | |
const auto device_caps = core.get_property("NPU", ov::device::capabilities); | |
if (std::find(device_caps.begin(), device_caps.end(), | |
"COMPILER_DYNAMIC_QUANTIZATION") != device_caps.end()) { | |
compiler_dq = true; | |
} | |
const bool compiler_dq = caps.end() != std::find(caps.begin(), caps.end(), "COMPILER_DYNAMIC_QUANTIZATION") |
std::string arch; | ||
int64_t max_tiles; | ||
bool compiler_dq; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is worth to have default values here, probably even incorrect (e.g., 0 as max_tiles)
Please, add |
Property to be added in openvinotoolkit/openvino#27789 |
@ilya-lavrenov what branch should I target for OV24.6? Or adding |
|
…inotoolkit#1258) Based on (yet to be) supported OV properties from the NPU Plugin enable NPUW_DQ_FULL. releases/2024/5 mirror: openvinotoolkit#1272 Dependencies * openvinotoolkit/openvino#27678 needs to be merged first * openvinotoolkit/openvino#27789
Based on (yet to be) supported OV properties from the NPU Plugin enable NPUW_DQ_FULL.
releases/2024/5 mirror: #1272
Dependencies
E-148336