packages/engine-cli/src/commands/create.js (2)

Line range hint 26-52: Consider enhancing error handling and consistency

While the current implementation works well, here are a few suggestions to further improve the createPlatform function:

1. For consistency, consider using fs.outputFileSync for both engine.config.js and package.json. You can use JSON.stringify(pkgContent, null, 2) to achieve the same formatting.

2. Enhance error handling by wrapping file system operations in try-catch blocks. This will provide more informative error messages if something goes wrong during file creation or copying.

3. Consider using a logging library or a custom logger instead of console.log directly. This will make it easier to manage logs across different environments.

Here's an example of how you might implement these suggestions:

import { promises as fsPromises } from 'fs'

// ... (rest of the imports)

const logger = console // Consider replacing this with a proper logging library

export async function createPlatform(name, options = {}) {
  const destPath = path.join(cwd(), name)

  try {
    if (await fsPromises.access(destPath).then(() => true).catch(() => false)) {
      throw new Error(`The ${name} folder already exists.`)
    }

    const mergedOptions = { ...defaultOptions, ...options }
    const templatePath = path.join(__dirname, '../template/designer/')

    await fsPromises.cp(templatePath, destPath, { recursive: true })

    const configContent = generateConfig(mergedOptions)
    const pkgContent = generatePackageJson(name, mergedOptions, templatePath)

    await fsPromises.writeFile(path.resolve(destPath, 'engine.config.js'), configContent)
    await fsPromises.writeFile(path.resolve(destPath, 'package.json'), JSON.stringify(pkgContent, null, 2))

    logger.log(chalk.green(`Create finished. Run the following command to start the project:\ncd ${name} && npm install && npm run dev`))
  } catch (error) {
    logger.error(chalk.red(`Creation failed: ${error.message}`))
  }
}

This refactored version uses async/await for better readability and error handling, and it uses consistent file writing methods.

---

Line range hint 54-61: Consider aligning createPlugin with createPlatform improvements

While not directly related to the PR changes, the createPlugin function could benefit from similar improvements as suggested for createPlatform:

1. Add error handling for file system operations.
2. Use async/await for consistency with an improved createPlatform function.
3. Check if the destination folder already exists before copying.

Here's a suggested implementation:

export async function createPlugin(name) {
  const sourcePath = path.join(__dirname, '../template/plugin/')
  const destPath = path.join(cwd(), name)

  try {
    if (await fsPromises.access(destPath).then(() => true).catch(() => false)) {
      throw new Error(`The ${name} folder already exists.`)
    }

    await fsPromises.cp(sourcePath, destPath, { recursive: true })

    logger.log(chalk.green(`Create finished. Run the following command to start the project:\ncd ${name} && npm install && npm run dev`))
  } catch (error) {
    logger.error(chalk.red(`Creation failed: ${error.message}`))
  }
}

This change would make createPlugin more robust and consistent with the improved createPlatform function.

Configuration used: CodeRabbit UI
Review profile: CHILL