packages/controller/js/http.js (2)

64-65: Approve the change with a suggestion for improved clarity.

The addition of the optional chaining operator ?. is a good fix for the updateTreeData error mentioned in the PR objectives. It prevents potential runtime errors if the method is not available.

However, to improve code clarity and maintainability, consider adding a comment explaining why updateTreeData might be undefined:

Consider adding a brief comment explaining the scenario where updateTreeData might be undefined:

 // 更新页面管理的列表，如果不存在，说明还没有打开过页面管理面板
+// Use optional chaining as updateTreeData may be undefined if the page management panel hasn't been opened
 pageSettingState.updateTreeData?.()

This comment will help future developers understand the reasoning behind the optional chaining usage.

---

Line range hint 38-83: Consider refactoring for improved maintainability and error handling.

While the current change addresses the immediate issue, there are opportunities to improve the overall structure and robustness of the handlePageUpdate function:

1. Error Handling: Enhance the error message in the catch block to provide more context about the failed operation.
2. Function Size: The function is handling multiple responsibilities. Consider breaking it down into smaller, more focused functions.
3. Environment-Specific Logic: The VSCode-specific code could be extracted into a separate function for better separation of concerns.

Here's a suggested refactoring approach:

1. Improve error handling:

.catch((err) => {
  useNotify({ 
    title: '保存失败', 
    message: `Failed to update page ${pageId}: ${err?.message || 'Unknown error'}`, 
    type: 'error' 
  })
  throw err; // Re-throw to allow caller to handle the error if needed
})

2. Extract VSCode-specific logic:

function handleVSCodeUpdate(pageId, params, routerChange) {
  generatePage({
    id: pageId,
    name: params.name,
    page_content: params.page_content
  })

  if (routerChange) {
    generateRouter({
      pageId,
      componentsTree: params
    })
  }
}

3. Simplify the main function:

export const handlePageUpdate = (pageId, params, routerChange, isCurEditPage) => {
  return http
    .post(`/app-center/api/pages/update/${pageId}`, params)
    .then((res) => {
      if (isVsCodeEnv) {
        handleVSCodeUpdate(pageId, params, routerChange)
      }
      updatePageState(params, isCurEditPage)
      return res
    })
    .catch(handleUpdateError)
}

function updatePageState(params, isCurEditPage) {
  const { pageSettingState } = usePage()
  const { setSaved } = useCanvas()
  
  pageSettingState.updateTreeData?.()
  pageSettingState.isNew = false
  useNotify({ message: '保存成功!', type: 'success' })
  setSaved(true)

  if (isCurEditPage) {
    const { setBreadcrumbPage } = useBreadcrumb()
    setBreadcrumbPage([params.name])
  }
}

function handleUpdateError(err) {
  useNotify({ 
    title: '保存失败', 
    message: `Failed to update page: ${err?.message || 'Unknown error'}`, 
    type: 'error' 
  })
  throw err;
}

These changes would make the code more modular, easier to test, and maintain.

Configuration used: CodeRabbit UI
Review profile: CHILL