Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unnecessary editor update options #2133

Merged
merged 3 commits into from
Dec 30, 2022
Merged

fix: unnecessary editor update options #2133

merged 3 commits into from
Dec 30, 2022

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Dec 28, 2022 •
edited
Loading

Types

  • 🐛 Bug Fixes

Background or solution

onDidChangeModel 中即使没有来自 contribution 提供的 options 也会调用一次 updateOptions,

upate-options

after

20221228133929

Changelog

  • fix: unnecessary editor update options

@github-actions github-actions bot added the 🐞 bug Something isn't working label Dec 28, 2022
@Aaaaash Aaaaash force-pushed the fix/unnecessary-update-editor-options branch from fccd851 to 186e174 Compare December 28, 2022 05:47
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 57.76% // Head: 57.78% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (c5e4bc3) compared to base (ad6ff9d).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2133      +/-   ##
==========================================
+ Coverage   57.76%   57.78%   +0.01%     
==========================================
  Files        1291     1313      +22     
  Lines       81585    82995    +1410     
  Branches    16993    17257     +264     
==========================================
+ Hits        47129    47958     +829     
- Misses      31333    31845     +512     
- Partials     3123     3192      +69
Flag Coverage Δ
jsdom 52.72% <85.71%> (+0.13%) ⬆️
node 16.51% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/editor/src/common/editor.ts 100.00% <ø> (ø)
...es/editor/src/browser/editor-collection.service.ts 66.66% <85.71%> (-1.07%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 59.33% <0.00%> (-0.83%) ⬇️
packages/search/src/browser/search.service.ts 49.53% <0.00%> (-0.24%) ⬇️
packages/monaco/src/browser/index.ts 0.00% <0.00%> (ø)
packages/core-browser/src/monaco/index.ts 100.00% <0.00%> (ø)
packages/monaco-enhance/src/browser/peek-view.ts 0.00% <0.00%> (ø)
packages/theme/src/common/color-tokens/editor.ts 100.00% <0.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 949a000 into main Dec 30, 2022
@erha19 erha19 deleted the fix/unnecessary-update-editor-options branch December 30, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ricbet Ricbet Ricbet approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aaaaash @Ricbet @erha19