Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pause debug will not open stackframe source file #2028

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: pause debug will not open stackframe source file #2028

merged 1 commit into from
Nov 30, 2022

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Nov 30, 2022 •
edited
Loading

Types

  • 🎉 New Features

Background or solution

Changelog

修复暂停调试时不会自动打开第一个堆栈源文件的问题

@Ricbet Ricbet requested review from hacke2 and erha19 November 30, 2022 06:13
@Ricbet Ricbet self-assigned this Nov 30, 2022
@Ricbet Ricbet linked an issue Nov 30, 2022 that may be closed by this pull request
[BUG] 调试断点暂停，但不会自动聚焦文件到断点位置 #2024
Closed
@github-actions github-actions bot added the 🐞 bug Something isn't working label Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 57.46% // Head: 57.44% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bf750ac) compared to base (31eed68).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2028      +/-   ##
==========================================
- Coverage   57.46%   57.44%   -0.02%     
==========================================
  Files        1292     1292              
  Lines       80861    80888      +27     
  Branches    16885    16893       +8     
==========================================
+ Hits        46467    46468       +1     
- Misses      31267    31290      +23     
- Partials     3127     3130       +3
Flag Coverage Δ
jsdom 52.31% <0.00%> (-0.02%) ⬇️
node 15.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/debug/src/browser/debug-session.ts 10.81% <0.00%> (-0.04%) ⬇️
...s/editor/src/browser/doc-model/saveParticipants.ts 23.86% <0.00%> (-6.44%) ⬇️
...sion/src/hosted/api/vscode/language/code-action.ts 65.00% <0.00%> (-1.67%) ⬇️
packages/core-node/src/bootstrap/shell-path.ts 81.81% <0.00%> (-0.33%) ⬇️
...tension/src/hosted/api/vscode/ext.host.language.ts 45.45% <0.00%> (-0.08%) ⬇️
packages/theme/src/common/color-tokens/editor.ts 100.00% <0.00%> (ø)
packages/extension/src/common/vscode/languages.ts 86.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 817191e into main Nov 30, 2022
@erha19 erha19 deleted the fix/debug-stopped-not-pause-stackframe branch November 30, 2022 09:09
@erha19 erha19 mentioned this pull request Dec 5, 2022
Merged
1 task
@github-actions github-actions bot mentioned this pull request Dec 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erha19 erha19 erha19 approved these changes

@hacke2 hacke2 Awaiting requested review from hacke2

Assignees

@Ricbet Ricbet

Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 调试断点暂停，但不会自动聚焦文件到断点位置
2 participants
@Ricbet @erha19