Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support detect configuration change from the parent directory #1976

Merged
merged 1 commit into from
Nov 22, 2022
Merged

feat: support detect configuration change from the parent directory #1976

merged 1 commit into from
Nov 22, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Nov 16, 2022

Types

  • 🎉 New Features

Background or solution

Kapture.2022-11-16.at.10.18.26.mp4

Changelog

support detect configuration change from the parent directory

@github-actions github-actions bot added the 🎨 feature feature required label Nov 16, 2022
@erha19 erha19 added this to the 2.22 milestone Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 57.49% // Head: 57.48% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (bdbef52) compared to base (aa87e1d).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
- Coverage   57.49%   57.48%   -0.02%     
==========================================
  Files        1286     1286              
  Lines       80542    80542              
  Branches    16853    16853              
==========================================
- Hits        46307    46296      -11     
- Misses      31119    31130      +11     
  Partials     3116     3116
Flag Coverage Δ
jsdom 52.23% <66.66%> (-0.02%) ⬇️
node 15.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/browser/abstract-resource-preference-provider.ts 82.55% <50.00%> (ø)
packages/file-service/src/browser/watcher.ts 100.00% <100.00%> (ø)
...ages/file-service/src/node/file-service-watcher.ts 72.34% <0.00%> (-4.26%) ⬇️
packages/utils/src/buffer.ts 30.81% <0.00%> (-2.33%) ⬇️
packages/utils/src/path.ts 78.19% <0.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 40258f7 into main Nov 22, 2022
@erha19 erha19 deleted the feat/support-detect-configuration-change-from-parent branch November 22, 2022 02:28
@github-actions github-actions bot mentioned this pull request Dec 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ricbet Ricbet Ricbet approved these changes

Assignees
No one assigned
Labels
🎨 feature feature required
Projects
None yet
Milestone
2.22
Development

Successfully merging this pull request may close these issues.
2 participants
@erha19 @Ricbet