refactor: optimize ajv load order #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantze
force-pushed
the
refactor/optimize-ajv
branch
3 times, most recently
from
7bf00be to
69c2306
Compare
yantze
force-pushed
the
refactor/optimize-ajv
branch
from
69c2306 to
47ad6e7
Compare
Codecov ReportBase: 57.68% // Head: 57.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
=======================================
Coverage 57.68% 57.68%
=======================================
Files 1269 1269
Lines 78979 78979
Branches 16528 16528
=======================================
Hits 45559 45559
Misses 30405 30405
Partials 3015 3015
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yantze
added a commit
that referenced
this pull request
Sep 26, 2022
erha19
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
ajv 在初始化和 compile 的时候会花费很长的时间，大概 80~100ms，可以通过延迟加载，在界面出现后，按需进行处理。
优化 menu 在启动逻辑中的引入顺序，避免过早的引入 menu -> keybinding -> monaco-editor 逻辑。这里可以看到引入 tab-bar-toolbar.js 后，会引入 menu 导致后面一连串的加载，导致加载延长，进入源码查看后发现，其实 tab-bar-toolbar 更多的是引入类型，结果把文件都引入后，导致后面的一连串反应。所以要拆分出类型和实现，以便优化启动逻辑
Changelog
优化 ajv 的加载顺序