Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable confirmation dialog on form submission #3619

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Add configurable confirmation dialog on form submission #3619

merged 8 commits into from
Dec 6, 2024

Conversation

FikriMilano
Copy link
Collaborator

@FikriMilano FikriMilano commented Nov 18, 2024 •
edited
Loading

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3618

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@FikriMilano FikriMilano requested a review from hamza-vd November 18, 2024 03:14
@FikriMilano FikriMilano self-assigned this Nov 18, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.2%. Comparing base (996914e) to head (c59b86c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3619     +/-   ##
=========================================
+ Coverage     27.4%   28.2%   +0.7%     
- Complexity     789     798      +9     
=========================================
  Files          282     282             
  Lines        14695   14403    -292     
  Branches      2632    2570     -62     
=========================================
+ Hits          4040    4071     +31     
+ Misses       10100    9792    -308     
+ Partials       555     540     -15
Flag Coverage Δ
engine 64.2% <100.0%> (+0.5%) ⬆️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ircore/engine/configuration/QuestionnaireConfig.kt 80.0% <100.0%> (+0.4%) ⬆️
...re/quest/ui/questionnaire/QuestionnaireActivity.kt 3.3% <ø> (+0.4%) ⬆️

... and 9 files with indirect coverage changes

@FikriMilano FikriMilano enabled auto-merge December 4, 2024 06:50
@FikriMilano FikriMilano disabled auto-merge December 4, 2024 07:39
@Rkareko
Copy link
Contributor

Rkareko commented Dec 4, 2024

@FikriMilano Could you resolve the merge conflicts

@pld pld added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit aef0fdc Dec 6, 2024
5 checks passed
@pld pld deleted the 3618-add-confirmation-dialog-on-submission branch December 6, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndegwamartin ndegwamartin ndegwamartin left review comments

@pld pld pld approved these changes

@hamza-vd hamza-vd Awaiting requested review from hamza-vd

Assignees

@FikriMilano FikriMilano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configurable confirmation dialog on form submission
4 participants
@FikriMilano @Rkareko @pld @ndegwamartin