Main | Performance improvements #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pld
previously approved these changes
Nov 16, 2024
pld
force-pushed
the
performance-improvements
branch
from
a6544a0 to
b235dde
Compare
pld
force-pushed
the
performance-improvements
branch
from
b235dde to
4386e9d
Compare
pld
force-pushed
the
performance-improvements
branch
from
c1ba1e3 to
fc25153
Compare
pld
approved these changes
Nov 16, 2024
pld
previously approved these changes
Nov 16, 2024
pld
force-pushed
the
performance-improvements
branch
from
278aa2e to
7cc606a
Compare
|
@ndegwamartin something's causing the quest build to hang/fail but it seems like it runs ok locally, wonder if there's some cache cleanup that needs to happen in the tests? |
Yeah that's strange, will look into it |
pld
approved these changes
Nov 18, 2024
11 tasks
qiarie
added a commit
that referenced
this pull request
Jan 15, 2025
* Test single transaction save for questionnaires * Caching questionnaires and their SM * spotless ran * Fetch search results in batches for when loading all * Fix infinite loop for mocks with FhirEngine#search in tests * [WIP] FhirEngine search integration tests * spotless ran * updated tests * WIP tests updated * resolved feedback * spotess ran * Upgrade FHIR SDK depenencies ⬆️ * Upragde SDC library * Replace JWT token parser library * Fix CQL Content Test * Fix unit tests ✅ * Refactor to remove Dispatch Provider * Fix unit test ✅ * Refactor Knowledge Manager Resources Persistance * Refactor CQL Content tests * Fix AppSettingModel unit tests ✅ * Refactor Cancel previous worflow to use native commands * Upgrade CI API level to 34 * Clean up Translations * Fix measure reporting * Fix Workflow Configuration * Fix QuestionnaireViewModel unit tests ✅ * Clean up WorkManager after running unit tests * Remove skyscreamer test dependency * Fix build 💚 * Clean up gradle dependencies configuration * Move measure reporting evaluation to BG thread * Fix MeasureReportRepositoryTest * Fix MeasureReportRepositoryTest * Fix MeasureReportViewModel unit tests ✅ Co-authored-by: Roy Munge <roywanyaga@gmail.com> * Fix Measure Reporting * Migrate Engine and Workflow libraries - Fix Measure reporting - Optimization PRs added * Refactor register filter with REL tags Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Update default pageSize to 15 Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Fix loading locations on map Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Refactor data structure used on base resource search results Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Process saveCredentials in the background * Refactor code Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Delete unnecessary code Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Refactor retrieving related resources Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Optimize data structures and perform parallel processing Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Use recent version of rules engine library Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Refactor implementation for decoding image resources to bitmap Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Fix related resource count on register Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Fix loading related resources This fix ensures all the nested related resources are loaded too. Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Batch related resource queries Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Map resources to RepositoryResourceData with async map Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Make infinite scroll the default register behavior Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Disable automatic intialization of emoji2 A lot of memory was used in heap during the allocation. Emojis are not used in the app so intializing them automatically is unnecessary. Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Run spotlessApply Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Update tests for displaying images (#3506) * Refactor load images tests for different views. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Remove unutilized imports. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Run spotlessApply Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Refactor load images tests for different views. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> * Resolve conflicts. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> --------- Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Refactor navigation to GeowidgetLauncher workflow Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Use dipatcher IO to handle questionnaire submission * Hotfix space_asterisk * Upgrade engine to v1.0.0-preview14.1-SNAPSHOT * Update infiniteScroll to not be default * Update sdk versions * Update integration Faker to fix error * Revert upgrade on workflow and knowledge libs * Upgrade FHIR SDK depenencies ⬆️ * Upragde SDC library * Replace JWT token parser library * Fix CQL Content Test * Fix unit tests ✅ * Refactor to remove Dispatch Provider * Fix unit test ✅ * Refactor Knowledge Manager Resources Persistance * Refactor CQL Content tests * Fix AppSettingModel unit tests ✅ * Refactor Cancel previous worflow to use native commands * Upgrade CI API level to 34 * Clean up Translations * Fix measure reporting * Fix Workflow Configuration * Fix QuestionnaireViewModel unit tests ✅ * Clean up WorkManager after running unit tests * Remove skyscreamer test dependency * Fix build 💚 * Clean up gradle dependencies configuration * Move measure reporting evaluation to BG thread * Fix MeasureReportRepositoryTest * Fix MeasureReportRepositoryTest * Fix MeasureReportViewModel unit tests ✅ Co-authored-by: Roy Munge <roywanyaga@gmail.com> * Fix Measure Reporting * Migrate Engine and Workflow libraries - Fix Measure reporting - Optimization PRs added * Update Workflow library - Fix build - Fix reporting NPE * Fix evaluate Population Measure * Update SDC snapshot to 14.1 * Remove unrecommended forced portrait format * Refactor from using deprecated KnowledgeManager methods loadResources * Clean up TOML catalog file * Revert Knowledge Manager and Workflow Library Upgrades * Display symbol instead of unicode * Refactor usage of FHIR JSONParser to support concurrency * Update FHIR SDK library versions * Geowidget configuration - Update Kujaku library version - Revert offline map downloads configuration via Kujaku network change receiver * Fix build 💚 - Fix code coverage reporting * SDK Engine to RC3 * Fix build * Fix failing ci tests * Update data-capture lib to v1.1.0-preview14-rc2-SNAPSHOT * Fix errors in tests * 🐛 Readd the eusm mg and bi flavour * 🔥 Remove unnecessary files * 🍻 Removing double flavour defination * Fix failing QuestionnaireViewModel tests * rename content cache to util.helper.CacheHelper * only 2 dots * remove unused cache var * use assign if null operator * format fixes * remove left over cache * update signature to require resourcetype * fix test call and remove dup test * refactor with setup and teardown * Revert "Caching questionnaires and their SM" This reverts commit 10465dafe49feff2571552fea37985a777c57c63. * Clean up 🗑 * Clean up caching to reset to main brach state --------- Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> Co-authored-by: L≡ZRS <12814349+LZRS@users.noreply.github.com> Co-authored-by: Aurangzaib Umer <aurangzaib.umer@venturedive.com> Co-authored-by: aurangzaibumer <35099184+aurangzaibumer@users.noreply.github.com> Co-authored-by: Martin Ndegwa <mndegwa@ona.io> Co-authored-by: Roy Munge <roywanyaga@gmail.com> Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com> Co-authored-by: Simon Njoroge <snjoroge@ona.io> Co-authored-by: Lentumunai Mark <90028422+Lentumunai-Mark@users.noreply.github.com> Co-authored-by: fikrimilano <fikrimilano1@gmail.com> Co-authored-by: Simon Kiarie <696759+qiarie@users.noreply.github.com> Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes [link to issue]
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile