Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor loading bitmap images #3546

Merged
merged 20 commits into from
Oct 14, 2024

Conversation

ellykits
Copy link
Collaborator

@ellykits ellykits commented Oct 8, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Rkareko and others added 20 commits September 25, 2024 13:01
Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>
* Refactor to use PdfConfig

Initially using QuestionnaireConfig for simplicity.

* Process multi QRs in HtmlPopulator

* Add new tag to check if Questionnaire has been submitted

* Remove subjectType since subjectReference is used

* Fix test and spotless

* Address review

* spotless

* Cleanup

* spotless

* Fix test

---------

Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>
      Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
* Add medication sort custom search param

* Run spotlessApply

* Fix failing time based test
* sync typo

* correct heading title

* update header definition for p2p

* upgrade packages
… to sync by have been selected (#3526)

* Don't show no results dialogue on map when locations selected on multiselect.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Fix failing tests.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

---------

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
* Add exit dialog

* Fix a typo

* Show Dialog only when Map or Register is visible

* PR feedback changes

* Fix failing check

* Remove incorrect test

* Refactor dialog condition logic

---------

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
)

* - Add the EUSM Burundi flavour
- Rename the exisiting EUSM flavour

* - Update the app naming

* - update the flavour naming
* - Add the EUSM Burundi flavour
- Rename the exisiting EUSM flavour

* - Update the app naming

* - update the flavour naming

* - Update the flavor naming
- Update the documentation

* - Update the flavors section of the documentation to clarify on the naming convention
* - Updating the infinite scroll paging
- Updating the behaviour after clearing search bar on the maps

* - spotless apply

* - Fix breaking tests on geo widget module

* - Fix tests

* - Run spotless

* - Import `LazyPagingItems`

* - Adding tests

* - Update the APK naming

* Ignore test to be refactored later

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* - Run spotless

* Update kujaku version.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

---------

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Co-authored-by: Lentumunai Mark <90028422+Lentumunai-Mark@users.noreply.github.com>
Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
@ellykits ellykits marked this pull request as ready for review October 14, 2024 18:34
@ellykits ellykits merged commit 58ec04d into fix-loading-nested-list-data Oct 14, 2024
@ellykits ellykits deleted the refactor-loading-bitmap-images branch October 14, 2024 18:34
ellykits added a commit that referenced this pull request Oct 18, 2024
* Include listRepositoryResourceDataMap to nested list widgets

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Fix loading related resources data for List widget

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Refactor loading bitmap images (#3546)

* Add date service to rules engine facts map (#3519)

* Add summary mode (#3500)

Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Refactor PDF config properties in QuestionnaireConfig (#3498)

* Refactor to use PdfConfig

Initially using QuestionnaireConfig for simplicity.

* Process multi QRs in HtmlPopulator

* Add new tag to check if Questionnaire has been submitted

* Remove subjectType since subjectReference is used

* Fix test and spotless

* Address review

* spotless

* Cleanup

* spotless

* Fix test

---------

Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Fix error validation highlighting not working when submit button is clicked bug (#3525)

* Change progress bar color to blue (#3428)

* update in-progress color on the map view. (#3529)

      Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Add medication sort custom search param (#3534)

* Add medication sort custom search param

* Run spotlessApply

* Fix failing time based test

* Pld docs adjustment (#3540)

* sync typo

* correct heading title

* update header definition for p2p

* upgrade packages

* Update Geowidget to only show the Set Location dialog if no Locations to sync by have been selected (#3526)

* Don't show no results dialogue on map when locations selected on multiselect.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Fix failing tests.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

---------

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Add Exit Dialog (#3487)

* Add exit dialog

* Fix a typo

* Show Dialog only when Map or Register is visible

* PR feedback changes

* Fix failing check

* Remove incorrect test

* Refactor dialog condition logic

---------

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>

* Refactor working with bitmap images

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Add the EUSM Burundi flavour and Rename the existing EUSM flavour (#3548)

* - Add the EUSM Burundi flavour
- Rename the exisiting EUSM flavour

* - Update the app naming

* - update the flavour naming

* Configure submit anyway button (#3535)

* Update the Burundi EUSM flavor (#3553)

* - Add the EUSM Burundi flavour
- Rename the exisiting EUSM flavour

* - Update the app naming

* - update the flavour naming

* - Update the flavor naming
- Update the documentation

* - Update the flavors section of the documentation to clarify on the naming convention

* Bum p up data capture version (#3547)

* Map search bug fixes (#3516)

* - Updating the infinite scroll paging
- Updating the behaviour after clearing search bar on the maps

* - spotless apply

* - Fix breaking tests on geo widget module

* - Fix tests

* - Run spotless

* - Import `LazyPagingItems`

* - Adding tests

* - Update the APK naming

* Ignore test to be refactored later

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* - Run spotless

* Update kujaku version.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

---------

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Co-authored-by: Lentumunai Mark <90028422+Lentumunai-Mark@users.noreply.github.com>
Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Fix loading related resources

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

---------

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: Rkareko <47570855+Rkareko@users.noreply.github.com>
Co-authored-by: FikriMilano <fikrimilano1@gmail.com>
Co-authored-by: Lentumunai Mark <90028422+Lentumunai-Mark@users.noreply.github.com>
Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Co-authored-by: Hamza Ahmed Khan <70560433+hamza-vd@users.noreply.github.com>
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Co-authored-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Fix failing UI tests

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Interpolate conditionalFhirPathExpressions in listResource (#3538)

To pass in evaluated rule variables

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Co-authored-by: Elly Kitoto <junkmailstoelly@gmail.com>

* Fix apply stack tint.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Apply opacity on view properties. (#3564)

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>

* Fix duplication of List view item

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>

---------

Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Co-authored-by: Rkareko <47570855+Rkareko@users.noreply.github.com>
Co-authored-by: FikriMilano <fikrimilano1@gmail.com>
Co-authored-by: Lentumunai Mark <90028422+Lentumunai-Mark@users.noreply.github.com>
Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Co-authored-by: Hamza Ahmed Khan <70560433+hamza-vd@users.noreply.github.com>
Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Co-authored-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Co-authored-by: L≡ZRS <12814349+LZRS@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants