Add the Practitioner selection screen on the In-app reporting workflow #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor naming of measure report module and date selection screens
Codecov Report
@@ Coverage Diff @@
## main #2605 +/- ##
=========================================
- Coverage 65.4% 65.3% -0.1%
- Complexity 1101 1148 +47
=========================================
Files 213 216 +3
Lines 9385 9744 +359
Branches 1866 1932 +66
=========================================
+ Hits 6140 6372 +232
- Misses 2047 2155 +108
- Partials 1198 1217 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ellykits
requested changes
Jul 20, 2023
| @@ -104,7 +105,15 @@ fun List<ActionConfig>.handleClickEvent( | |||
| } | |||
| } | |||
| ApplicationWorkflow.LAUNCH_REPORT -> { | |||
| val args = bundleOf(Pair(NavigationArg.REPORT_ID, actionConfig.id)) | |||
| val interpolatedParams = interpolateActionParamsValue(actionConfig, resourceData) | |||
There was a problem hiding this comment.
Can this interpolation be done before the when clause so all branches can benefit from it?
pld
reviewed
Jul 20, 2023
...quest/src/test/java/org/smartregister/fhircore/quest/util/extensions/ConfigExtensionsTest.kt
Show resolved
Hide resolved
pld
approved these changes
Jul 21, 2023
AbdulWahabMemon
added a commit
that referenced
this pull request
Jul 25, 2023
* main: Add View and Row widget documentation (#2614) Document spacer and divider widgets. (#2612) Add the Practitioner selection screen on the In-app reporting workflow (#2605) Add enableFamilyRegistration test for GeoWidgetfragment (#2607) Improved UX for non proxy mode development 🔨 Update docs - added sync insights (#2600) Fixes the app showing a "Sync Complete" message even on sync failure (#2599) Retrieve related resources without necessarily having to pass a reference. (#2595) Add tests to verify LoginScreen error states (#2589) Rw docs update (#2588) Manifest Binaries request batching (#2583) remove about section (#2587) Pld doc updates (#2584) fix cname (#2586) Add Encounter_Location type (#2585) passing empty bundle instead of null to trigger the careplan when we don't have any bundle resource (#2432) Configure resource id for profile launch (#2581)
qiarie
pushed a commit
that referenced
this pull request
Jan 15, 2025
#2605) * Pass practitioner id to measureReportViewModel * Refactor runMeasureReport to use practitioner id Refactor naming of measure report module and date selection screens * Refactor order of measure report screens * Update unit tests * Update column and row properties to handle click actions * Update unit tests * Fix failing tests * Run spotless Apply * Add optional click handling for column view * Refactor extraction of practitioner and resource id * Filter practitioner id by key * Update unit test * Add practitioner id to list of subjects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2472
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile