Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MWCore] Add Resource Tagging #2499

Merged
merged 45 commits into from
Aug 1, 2023
Merged

[MWCore] Add Resource Tagging #2499

merged 45 commits into from
Aug 1, 2023

Conversation

sevenreup
Copy link

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@sevenreup sevenreup changed the base branch from main to mwcore-dev June 27, 2023 13:41
@sevenreup sevenreup self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #2499 (3449870) into mwcore-dev (5e40d4c) will decrease coverage by 1.0%.
The diff coverage is 60.3%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mwcore-dev   #2499     +/-   ##
==============================================
- Coverage          68.4%   67.4%   -1.0%     
+ Complexity          902     877     -25     
==============================================
  Files               156     160      +4     
  Lines              6958    7139    +181     
  Branches            996     998      +2     
==============================================
+ Hits               4761    4817     +56     
- Misses             1570    1693    +123     
- Partials            627     629      +2
Flag Coverage Δ
engine 67.4% <60.3%> (-1.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ngine/data/local/register/dao/FamilyRegisterDao.kt 2.5% <0.0%> (ø)
...gine/data/local/register/dao/TracingRegisterDao.kt 79.7% <0.0%> (+0.6%) ⬆️
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 79.5% <0.0%> (ø)
...gister/fhircore/engine/sync/SyncListenerManager.kt 0.0% <0.0%> (ø)
...hircore/engine/ui/userprofile/UserProfileScreen.kt 0.0% <0.0%> (ø)
...rcore/engine/util/extension/FhirEngineExtension.kt 0.0% <0.0%> (ø)
...hircore/engine/util/extension/ResourceExtension.kt 69.0% <13.3%> (-5.5%) ⬇️
...hircore/engine/ui/appsetting/AppSettingActivity.kt 27.7% <20.0%> (-29.4%) ⬇️
...rtregister/fhircore/engine/ui/login/LoginScreen.kt 73.4% <22.2%> (-3.6%) ⬇️
...e/engine/ui/questionnaire/QuestionnaireActivity.kt 77.3% <25.0%> (+0.2%) ⬆️
... and 31 more

... and 16 files with indirect coverage changes

@sevenreup sevenreup marked this pull request as draft June 29, 2023 06:15
@LZRS LZRS force-pushed the mwcore-migrate-auth-code branch 2 times, most recently from 25a5c93 to f4e23ab Compare July 30, 2023 14:58
@LZRS LZRS force-pushed the mwcore-migrate-auth-code branch from f4e23ab to 3c91f1b Compare July 30, 2023 15:48
@sevenreup sevenreup requested a review from LZRS August 1, 2023 07:01
@sevenreup sevenreup marked this pull request as ready for review August 1, 2023 07:01
@sevenreup sevenreup merged commit ef5f9fa into mwcore-dev Aug 1, 2023
@sevenreup sevenreup deleted the mwcore-migrate-auth-code branch August 1, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LZRS LZRS LZRS approved these changes

Assignees

@sevenreup sevenreup

Labels
Malawi CORE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevenreup @LZRS