Create command 'rosa list user-roles' #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oriAdler
force-pushed
the
list-user-roles
branch
from
d13e017 to
3aea4fe
Compare
zgalor
reviewed
Feb 8, 2022
zgalor
reviewed
Feb 8, 2022
zgalor
reviewed
Feb 8, 2022
pvasant
reviewed
Feb 8, 2022
openshift-ci
bot
added
the
do-not-merge/work-in-progress
oriAdler
force-pushed
the
list-user-roles
branch
4 times, most recently
from
fc048e6 to
03d5f51
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
zgalor
reviewed
Feb 9, 2022
zgalor
reviewed
Feb 9, 2022
zgalor
reviewed
Feb 9, 2022
oriAdler
force-pushed
the
list-user-roles
branch
from
03d5f51 to
ac2ec29
Compare
pvasant
reviewed
Feb 9, 2022
pvasant
reviewed
Feb 9, 2022
The new command is implemented similarly to the `rosa list ocm-roles` command. The code checks if a `role name` contains the `User` infix, and in addition, checks if the role has the tag `rosa_role_type: User`, because 'user' is a common word. Related: SDA-5412
oriAdler
force-pushed
the
list-user-roles
branch
from
ac2ec29 to
c4104a6
Compare
|
@oriAdler: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oriAdler, pvasant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new command is implemented similarly to the
rosa list ocm-rolescommand.The code checks if a
role namecontains theUserinfix and in addition,checks if the role has the tag
rosa_role_type: User, because 'user' is a common word.Related: SDA-5412