This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Expose haproxy-sni-proxy mapped ports as environmental variables #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test][extended:cartridge,gear] |
|
Origin Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests/2946/) |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8392/) |
|
[test] |
|
@mfojtik review please? |
|
|
||
| # Add env variable for the public port mapping. | ||
| port=url.gsub(/.*?(\d+)$/,'\1') | ||
| @container.add_env_var(endpoint.public_port_name,port) |
There was a problem hiding this comment.
How about:
@container.add_env_var(endpoint.public_port_name, url[/(\d+)$/])
This will work if we are sure the ":port" part will always be there.
bparees
force-pushed
the
sni_port_env
branch
from
0faeb42 to
d204bd7
Compare
|
Evaluated for origin up to d204bd7 |
|
@mfojtik fixed the substitution, anything else? |
|
@bparees LGTM, you want me to merge this or wait for tests to finish? |
|
@mfojtik was waiting for the tests. [merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/merge_pull_requests/6021/) (Image: devenv_5181) |
|
Evaluated for online up to d204bd7 |
openshift-bot
pushed a commit
that referenced
this pull request
Sep 22, 2014
Merged by openshift-bot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1143991