-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create template file for image repos #884
Conversation
da56781
to
8994a41
Compare
@smarterclayton i think is the image repo list you wanted me to create... not sure exactly where you wanted it placed or what sort of doc you want around it though. |
(also this file is setup to pull from dockerhub, not the internal docker-registry. not sure which you wanted but this is more usable out of the box) |
8994a41
to
b652424
Compare
This way is better for now |
LGTM - we should be able to |
b652424
to
f164ddd
Compare
@smarterclayton added to test-cmd, which includes validation that Status gets populated, is that sufficient or is there still something you want to see in e2e? |
It's fine for now. e2e I think we should maybe get to the point where we can do new-app off it (once new-app works). |
[merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/822/) (Image: devenv-fedora_704) |
Evaluated for origin up to f164ddd |
No description provided.