Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create template file for image repos #884

Merged
merged 1 commit into from
Feb 4, 2015

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Feb 4, 2015

No description provided.

@bparees bparees force-pushed the imagerepo_template branch from da56781 to 8994a41 Compare February 4, 2015 19:42
@bparees
Copy link
Contributor Author

bparees commented Feb 4, 2015

@smarterclayton i think is the image repo list you wanted me to create... not sure exactly where you wanted it placed or what sort of doc you want around it though.

@bparees
Copy link
Contributor Author

bparees commented Feb 4, 2015

(also this file is setup to pull from dockerhub, not the internal docker-registry. not sure which you wanted but this is more usable out of the box)

@bparees bparees force-pushed the imagerepo_template branch from 8994a41 to b652424 Compare February 4, 2015 19:51
@smarterclayton
Copy link
Contributor

This way is better for now

@smarterclayton
Copy link
Contributor

LGTM - we should be able to osc create -f <url_to_this> and get it booted into that namespace. Can you add this to hack/test-cmd.sh during run (to ensure it validates) and to test-end-to-end and verify that it gets a status url?

@bparees bparees force-pushed the imagerepo_template branch from b652424 to f164ddd Compare February 4, 2015 21:20
@bparees
Copy link
Contributor Author

bparees commented Feb 4, 2015

@smarterclayton added to test-cmd, which includes validation that Status gets populated, is that sufficient or is there still something you want to see in e2e?

@smarterclayton
Copy link
Contributor

It's fine for now. e2e I think we should maybe get to the point where we can do new-app off it (once new-app works).

@smarterclayton
Copy link
Contributor

[merge]

@smarterclayton smarterclayton added this to the 0.3.0 (beta1) milestone Feb 4, 2015
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/822/) (Image: devenv-fedora_704)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to f164ddd

openshift-bot pushed a commit that referenced this pull request Feb 4, 2015
@openshift-bot openshift-bot merged commit 93c7d5d into openshift:master Feb 4, 2015
@bparees bparees deleted the imagerepo_template branch February 5, 2015 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants