Rewrite and re-scope deployment documentation #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a follow-on to #584 |
6 tasks
| } | ||
| ``` | ||
|
|
||
| In this example, when the `latest` tag value for the `imageRepository` named `openshift/origin-ruby-sample` changes, every container in the `deploymentConfig` matching those in `containerNames` will be updated with the new tag value, and a new `deployment` will be created. |
There was a problem hiding this comment.
"every container in the deploymentConfig matching those in containerNames" is a bit confusing to me.
maybe: the containers specified in containerNames for deploymentConfig D will be updated ...
There was a problem hiding this comment.
Incorporated, thanks
ironcladlou
force-pushed
the
deployment-docs
branch
2 times, most recently
from
0c14a70 to
0e4d8c6
Compare
Make the deployment doc less of a low level technical document/proposal mashup, and rewrite it for end-user consumption. Architecture and technical details can be moved to a new document. The upstream proposal will also be a new document.
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/589/) (Image: devenv-fedora_528) |
|
[merge] looks like jenkins timeout |
|
Evaluated for origin up to 0e4d8c6 |
openshift-bot
pushed a commit
that referenced
this pull request
Jan 12, 2015
Merged by openshift-bot
deads2k
pushed a commit
to deads2k/origin
that referenced
this pull request
Jul 26, 2017
Merged by openshift-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the deployment doc less of a low level technical document/proposal
mashup, and rewrite it for end-user consumption. Architecture and
technical details can be moved to a new document. The upstream proposal
will also be a new document.