Support swaggerapi from OpenShift #571
Conversation
smarterclayton
force-pushed
the
support_swagger
branch
from
152433a to
26000e6
Compare
smarterclayton
changed the title
smarterclayton
force-pushed
the
support_swagger
branch
2 times, most recently
from
27a8d6f to
1c695c7
Compare
|
@deads2k review please |
|
[test] |
|
Origin Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/668/) |
|
As a general note, it's nice to be able to explore and try the various REST APIs that we have, but the information available is more superficial than the schemas they are replacing. I definitely see the benefit of not paying a doc tax for every change made to the schema, but is there any way to annotate our types to generate more descriptive docs? In java it would be something that had harvested javadoc or used a custom doclet tag. |
Also allow swagger to be optionally enabled, so we can define our own
Exposes /swaggerapi/ which includes all of the OpenShift resources in a registered form.
smarterclayton
force-pushed
the
support_swagger
branch
from
1c695c7 to
da074d1
Compare
|
Yes, upstream has already plumbed field annotation on the schema, and more will come. |
|
Comment addressed |
|
LGTM |
|
[merge] |
|
Origin Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/538/) (Image: devenv-fedora_492) |
|
Evaluated for origin up to da074d1 |
Merged by openshift-bot
Allows us to start showing API docs. Upstream dependency is kubernetes/kubernetes#2945.
Once this lands, you can start openshift with global CORS
openshift start --cors-allowed-origins=.*and then go to http://openshift3swagger-claytondev.rhcloud.com