Copy volume mounts to hook pods #5664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bubble for now |
ironcladlou
force-pushed
the
hook-volume-mounts
branch
from
2814371 to
0c791f6
Compare
|
LGTM |
smarterclayton
added
approved
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
[test] |
|
Needs rebase |
openshift-bot
added
the
needs-rebase
Copy volume mounts to hook pods matching any volumes which were also copied to the hook pod. Otherwise the mapped volumes are inaccessible to the hook container.
ironcladlou
force-pushed
the
hook-volume-mounts
branch
from
0c791f6 to
842dee6
Compare
|
Rebased, [test]ing again |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6876/) (Image: devenv-rhel7_2638) |
|
Evaluated for origin test up to 842dee6 |
openshift-bot
removed
the
needs-rebase
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6876/) |
|
@smarterclayton @liggitt rebased and tests are still good, please put it back in the merge queue. |
|
[merge] |
|
Evaluated for origin merge up to 842dee6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy volume mounts to hook pods matching any volumes which were also
copied to the hook pod. Otherwise the mapped volumes are inaccessible
to the hook container.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1270187