Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-47796: fix year for string compare #29398

Merged
merged 1 commit into from
Jan 7, 2025
Merged

OCPBUGS-47796: fix year for string compare #29398

merged 1 commit into from
Jan 7, 2025

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jan 6, 2025

For the machine monior tests we compare directly against the error message. The year is included there so we will inject 2024 for those tests.

This way the tests won't fail in 2025.

For the lease tests we don't actually use the year so we can use the current year without any issue.

Note:

I am not sure if this is also failing for 4.17..

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 6, 2025
@openshift-ci-robot
Copy link

@kannon92: This pull request references Jira Issue OCPBUGS-47796, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

For the machine monior tests we compare directly against the error message. The year is included there so we will inject 2024 for those tests.

This way the tests won't fail in 2025.

For the lease tests we don't actually use the year so we can use the current year without any issue.

Note:

I am not sure if this is also failing for 4.17..

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kannon92
Copy link
Contributor Author

kannon92 commented Jan 6, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 6, 2025
@openshift-ci-robot
Copy link

@kannon92: This pull request references Jira Issue OCPBUGS-47796, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning January 6, 2025 17:03
@kannon92
Copy link
Contributor Author

kannon92 commented Jan 6, 2025

/assign @dgoodwin

@xueqzhan
Copy link
Contributor

xueqzhan commented Jan 6, 2025

/lgtm

Thanks for fixing this.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 929fc7c and 2 for PR HEAD f9bb992 in total

@kannon92
Copy link
Contributor Author

kannon92 commented Jan 6, 2025

@xueqzhan

should we override some of these jobs to get the required unit tests passing?

@kannon92
Copy link
Contributor Author

kannon92 commented Jan 6, 2025

/test e2e-aws-ovn-serial

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 169e7a3 and 1 for PR HEAD f9bb992 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

@kannon92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-serial f9bb992 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node f9bb992 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-kube-apiserver-rollout f9bb992 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/okd-scos-e2e-aws-ovn f9bb992 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9ef4f33 into openshift:master Jan 7, 2025
25 of 29 checks passed
@openshift-ci-robot
Copy link

@kannon92: Jira Issue OCPBUGS-47796: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-47796 has been moved to the MODIFIED state.

In response to this:

For the machine monior tests we compare directly against the error message. The year is included there so we will inject 2024 for those tests.

This way the tests won't fail in 2025.

For the lease tests we don't actually use the year so we can use the current year without any issue.

Note:

I am not sure if this is also failing for 4.17..

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kannon92
Copy link
Contributor Author

kannon92 commented Jan 7, 2025

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@kannon92: new pull request created: #29403

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 7, 2025
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202501071907.p0.g9ef4f33.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@dgoodwin dgoodwin

@xueqzhan xueqzhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kannon92 @openshift-ci-robot @xueqzhan @openshift-cherrypick-robot @openshift-bot @dgoodwin