Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: address MetricsCollectionProfiles failures on metal platform #29297

Merged
merged 1 commit into from
Nov 18, 2024
Merged

NO-JIRA: address MetricsCollectionProfiles failures on metal platform #29297

merged 1 commit into from
Nov 18, 2024

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Nov 14, 2024 •
edited
Loading

Issues with this test suite failing on bare-metal were caused due to a missing config.yaml key in CMO's configuration (logs).

fail [github.com/openshift/origin/test/extended/prometheus/prometheus.go:405]: could not determine if Telemetry is enabled: openshift-monitoring/cluster-monitoring-config data lacks a config.yaml key: map[]

@rexagod
Copy link
Member Author

rexagod commented Nov 14, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview
/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

@rexagod: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a0cb0820-a2dc-11ef-8215-3138e27abe68-0

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@rexagod rexagod force-pushed the 3775-followup-metal branch from 7c63f1d to e26ffa1 Compare November 14, 2024 23:35
@rexagod
fix: address MetricsCollectionProfiles failures on metal platform
df2e111 
Issues with this test suite failing on bare-metal were caused due to a
missing `config.yaml` key in CMO's configuration.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod rexagod force-pushed the 3775-followup-metal branch from e26ffa1 to df2e111 Compare November 14, 2024 23:37
@rexagod
Copy link
Member Author

rexagod commented Nov 14, 2024

/payload-abort

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

@rexagod: aborted active payload jobs for pull request #29297

@rexagod
Copy link
Member Author

rexagod commented Nov 14, 2024

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview
/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

@rexagod: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-dualstack-techpreview
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/860635f0-a2e1-11ef-8f08-cba9e5f65e23-0

@rexagod
Copy link
Member Author

rexagod commented Nov 15, 2024

/test e2e-gcp-ovn-techpreview

@rexagod
Copy link
Member Author

rexagod commented Nov 15, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn df2e111 link false /test e2e-metal-ipi-ovn
ci/prow/e2e-aws-ovn-kube-apiserver-rollout df2e111 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout df2e111 link false /test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-agnostic-ovn-cmd df2e111 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-single-node df2e111 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jan--f
Copy link
Contributor

jan--f commented Nov 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rexagod rexagod changed the title fix: address MetricsCollectionProfiles failures on metal platform NO-JIRA: address MetricsCollectionProfiles failures on metal platform Nov 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@openshift-ci-robot
Copy link

@rexagod: This pull request explicitly references no jira issue.

In response to this:

Issues with this test suite failing on bare-metal were caused due to a missing config.yaml key in CMO's configuration (logs).

fail [github.com/openshift/origin/test/extended/prometheus/prometheus.go:405]: could not determine if Telemetry is enabled: openshift-monitoring/cluster-monitoring-config data lacks a config.yaml key: map[]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2ae2adf and 2 for PR HEAD df2e111 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 57f9053 into openshift:master Nov 18, 2024
24 of 29 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202411182236.p0.g57f9053.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees

@jan--f jan--f

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rexagod @jan--f @openshift-ci-robot @openshift-bot