Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1821280: Unable to provision vSphere volume #25166

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Bug 1821280: Unable to provision vSphere volume #25166

merged 1 commit into from
Jun 23, 2020

Conversation

Danil-Grigorev
Copy link
Contributor

Cherry-pick of kubernetes/kubernetes#90836

Add ability for vSphere to reconnect to cached nodes on secret update or create

  • Refactor getNodeInfo to be more descriptive
  • Add log output testing for secret update
  • Ensure all nodes refreshed on secret change
  • Add config option to disable secret management

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jun 19, 2020
@openshift-ci-robot
Copy link

@Danil-Grigorev: This pull request references Bugzilla bug 1821280, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1821280: Unable to provision vSphere volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 19, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jun 19, 2020
@Danil-Grigorev Danil-Grigorev force-pushed the update-connection-on-secret-change branch from 01e4080 to 3bc49f9 Compare June 19, 2020 08:27
@enxebre
Copy link
Member

enxebre commented Jun 19, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@enxebre
Copy link
Member

enxebre commented Jun 19, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. labels Jun 19, 2020
@openshift-ci-robot
Copy link

@enxebre: This pull request references Bugzilla bug 1821280, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@enxebre
Copy link
Member

enxebre commented Jun 19, 2020 •
edited
Loading

/hold
cherry-pick does not applies cleanly. @Danil-Grigorev we need to review upstream skew.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 19, 2020
@Danil-Grigorev
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2020
@Danil-Grigorev Danil-Grigorev force-pushed the update-connection-on-secret-change branch 2 times, most recently from 7ba419a to 5b7d97a Compare June 22, 2020 10:59
@Danil-Grigorev
UPSTREAM: 90836: Add ability for vSphere to reconnect to cached nodes…
4dafee1 
… on secret update or create

- Refactor getNodeInfo to be more descriptive
- Add log output testing for secret update
- Ensure all nodes refreshed on secret change
- Add config option to disable secret management
@Danil-Grigorev Danil-Grigorev force-pushed the update-connection-on-secret-change branch from 5b7d97a to 4dafee1 Compare June 22, 2020 11:21
@enxebre
Copy link
Member

enxebre commented Jun 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@Danil-Grigorev
Copy link
Contributor Author

@eparis @bparees @smarterclayton Guys, may I get an approval?

@bparees
Copy link
Contributor

bparees commented Jun 23, 2020

we appear to be vendoring this code twice:
vendor/k8s.io/kubernetes/staging/src/k8s.io/legacy-cloud-providers/vsphere
vendor/k8s.io/legacy-cloud-providers/vsphere

are they in sync? do they need to be?

@Danil-Grigorev
Copy link
Contributor Author

staging/src/k8s.io/legacy-cloud-providers/vsphere

@bparees If you mean the second vendoring solely for the tests, then it is needed, as it is now required for unit tests to import klog package for testing. Without it upstream bazel build is failing.

@bparees
Copy link
Contributor

bparees commented Jun 23, 2020

@bparees If you mean the second vendoring solely for the tests, then it is needed, as it is now required for unit tests to import klog package for testing. Without it upstream bazel build is failing.

so is there a reason this PR isn't bumping it?

@Danil-Grigorev
Copy link
Contributor Author

@bparees There was an error in CI when I cherry-picked bazel build file as is. klog/v2 is not yet used anywhere in origin, it would be better if this PR will only fix the BZ, without introducing some additional version bumps. I guess it will be done on rebase.

@bparees
Copy link
Contributor

bparees commented Jun 23, 2020

ok.

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, Danil-Grigorev, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 369171c into openshift:master Jun 23, 2020
@openshift-ci-robot
Copy link

@Danil-Grigorev: All pull requests linked via external trackers have merged: openshift/origin#25166, kubernetes/kubernetes#90836. Bugzilla bug 1821280 has been moved to the MODIFIED state.

In response to this:

Bug 1821280: Unable to provision vSphere volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Danil-Grigorev @openshift-ci-robot @enxebre @bparees @openshift-bot @openshift-merge-robot