Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1841035: Add volumesnapshotclass to default RBAC test #25137

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

jsafrane
Copy link
Contributor

Authenticated user will get capability to read VolumeSnapshotClasses soon. The test must be updated before the actual RBAC change is merged, so CI works both before the update and after.

The test tolerates 15 extra RBAC rules, so it's going to pass, only write this to stdout:

Jun 17 10:07:55.555: INFO: test data for system:authenticated has too many unnecessary permissions:
{APIGroups:["snapshot.storage.k8s.io"], Resources:["volumesnapshotclasses"], Verbs:["get" "list" "watch"]}

This resolves when cluster-csi-snapshot-controller-operator actually includes the new RBAC rules.

/assign @deads2k

Authenticated user will get capability to read VolumeSnapshotClasses soon.
The test must be updated before the actual RBAC change is merged, so CI
works both before the update and after.

The test tolerates 15 extra RBAC rules, so it's going to pass and write
this to stdout:

Jun 17 10:07:55.555: INFO: test data for system:authenticated has too many unnecessary permissions:
{APIGroups:["snapshot.storage.k8s.io"], Resources:["volumesnapshotclasses"], Verbs:["get" "list" "watch"]}

This resolves when cluster-csi-snapshot-controller-operator actually
includes the new RBAC rules.
@jsafrane jsafrane changed the title Add volumesnapshotclass to default RBAC test Bug 1841035: Add volumesnapshotclass to default RBAC test Jun 17, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 17, 2020
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Bugzilla bug 1841035, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1841035: Add volumesnapshotclass to default RBAC test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 17, 2020
@deads2k
Copy link
Contributor

deads2k commented Jun 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cb7df45 into openshift:master Jun 20, 2020
@openshift-ci-robot
Copy link

@jsafrane: Some pull requests linked via external trackers have merged: openshift/origin#25137, openshift/openshift-apiserver#113. The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1841035: Add volumesnapshotclass to default RBAC test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants