-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1841035: Add volumesnapshotclass to default RBAC test #25137
Bug 1841035: Add volumesnapshotclass to default RBAC test #25137
Conversation
Authenticated user will get capability to read VolumeSnapshotClasses soon. The test must be updated before the actual RBAC change is merged, so CI works both before the update and after. The test tolerates 15 extra RBAC rules, so it's going to pass and write this to stdout: Jun 17 10:07:55.555: INFO: test data for system:authenticated has too many unnecessary permissions: {APIGroups:["snapshot.storage.k8s.io"], Resources:["volumesnapshotclasses"], Verbs:["get" "list" "watch"]} This resolves when cluster-csi-snapshot-controller-operator actually includes the new RBAC rules.
@jsafrane: This pull request references Bugzilla bug 1841035, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@jsafrane: Some pull requests linked via external trackers have merged: openshift/origin#25137, openshift/openshift-apiserver#113. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Authenticated user will get capability to read VolumeSnapshotClasses soon. The test must be updated before the actual RBAC change is merged, so CI works both before the update and after.
The test tolerates 15 extra RBAC rules, so it's going to pass, only write this to stdout:
This resolves when cluster-csi-snapshot-controller-operator actually includes the new RBAC rules.
/assign @deads2k