Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ClusterNetwork REST GetAttrs #14853

Merged
merged 1 commit into from
Jun 25, 2017
Merged

Fix ClusterNetwork REST GetAttrs #14853

merged 1 commit into from
Jun 25, 2017

Conversation

enj
Copy link
Contributor

@enj enj commented Jun 23, 2017

@soltysh we used the wrong GetAttrs func during the move to CompleteWithOptions.

Signed-off-by: Monis Khan mkhan@redhat.com

[test]

@deads2k @liggitt PTAL

@enj
Fix ClusterNetwork REST GetAttrs
16f8f30 
Signed-off-by: Monis Khan <mkhan@redhat.com>
simo5
simo5 approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, i there a way to have a test to ctach something like this in future ?

@deads2k
Copy link
Contributor

deads2k commented Jun 23, 2017

Changes look good to me, i there a way to have a test to ctach something like this in future ?

Probably want to consider a different option, like reflecting through the object to create the map.

@mfojtik
Copy link
Contributor

mfojtik commented Jun 23, 2017

LGTM

[severity:blocker]

@enj
Copy link
Contributor Author

enj commented Jun 23, 2017

[merge]

@enj enj mentioned this pull request Jun 23, 2017
Open
@enj
Copy link
Contributor Author

enj commented Jun 23, 2017

re[test] flake on #14823 #14043 #14857

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 16f8f30

@soltysh
Copy link
Contributor

soltysh commented Jun 23, 2017

😨 how come we missed it... sigh
LGTM

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2554/) (Base Commit: 4917a3e) (PR Branch Commit: 16f8f30)

This was referenced Jun 24, 2017
Closed
Closed
@enj
Copy link
Contributor Author

enj commented Jun 24, 2017

re[merge] flake on #14122 #14385

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 16f8f30

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 25, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1121/) (Base Commit: d41a748) (PR Branch Commit: 16f8f30) (Extended Tests: blocker) (Image: devenv-rhel7_6396)

@openshift-bot openshift-bot merged commit e0c7707 into openshift:master Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simo5 simo5 simo5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enj @deads2k @mfojtik @openshift-bot @soltysh @simo5