Bring image building logic into the Bash library #14534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure dockerfile support isn't used by centos paas sig?
|
No. I'll check. |
stevekuznetsov
force-pushed
the
skuznets/cleanup-image-bash
branch
from
e3d5028 to
5b27936
Compare
stevekuznetsov
force-pushed
the
skuznets/cleanup-image-bash
branch
from
5b27936 to
8022297
Compare
|
@smarterclayton confirmed they do not use them |
|
sgtm then
…On Fri, Jun 9, 2017 at 1:39 PM, Steve Kuznetsov ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton> confirmed they do not
use them
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14534 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p8vfYUL4Nqe-FB3Stz-jpnnTJqzDks5sCYM4gaJpZM4N0hfK>
.
|
stevekuznetsov
force-pushed
the
skuznets/cleanup-image-bash
branch
4 times, most recently
from
b2bf38e to
896880b
Compare
stevekuznetsov
force-pushed
the
skuznets/cleanup-image-bash
branch
from
896880b to
ec7e1c2
Compare
Previously, useful logic for building images like the choice to tag images with `:latest` as well as `:sha`, automatic re-try logic, `git` cleanup, nice output printing, etc, were all local to the top-level `hack/build-images.sh` entrypoint. There's no reason for that to be the case and as other people find themselves needing those features, we should just expose all of that with `os::build::image`. This is not an entirely backwards compatible patch. The following changes were made: - support for explicitly providing a Dockerfile was removed from the signature of `os::build::image` as this was an entirely unused feature. - the order of arguments was re-arranged so that all of the image build utilites were in alignment -- first the tag, then the dir, etc. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/cleanup-image-bash
branch
from
ec7e1c2 to
9753bf5
Compare
|
Evaluated for origin test up to 9753bf5 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/2190/) (Base Commit: a5b8471) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 8 |
|
Evaluated for origin merge up to 9753bf5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, useful logic for building images like the choice to tag
images with
:latestas well as:sha, automatic re-try logic,gitcleanup, nice output printing, etc, were all local to the top-level
hack/build-images.shentrypoint. There's no reason for that to be thecase and as other people find themselves needing those features, we
should just expose all of that with
os::build::image.This is not an entirely backwards compatible patch. The following
changes were made:
signature of
os::build::imageas this was an entirely unusedfeature.
utilites were in alignment -- first the tag, then the dir, etc.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
Depends on #14435
/cc @smarterclayton PTAL last commit
[test]