Builds page - group builds by build config and show more details for build configs #1134
Conversation
|
|
| <div>Output image: {{build.parameters.output.imageTag}}</div> | ||
| <div>Output image registry: {{build.parameters.output.registry}}</div> | ||
| </div> | ||
| <div ng-switch="buildConfig.parameters.output.to.kind"> |
There was a problem hiding this comment.
it is possible to have output.dockerImageReference instead of output.to
There was a problem hiding this comment.
i'm not seeing output.dockerImageReference coming back from the API
There was a problem hiding this comment.
It's here eventually (although deprecated) you can look into ImageTag and Registry but DockerImageReference should take precedence over the two (see latter lines in the link).
There was a problem hiding this comment.
@csrwng can you send me a sample template that has a build that would produce dockerImageReference in the API output, all the examples under the sample-app do not return dockerImageReference
There was a problem hiding this comment.
Sample build config is here: https://gist.github.com/csrwng/61628e83581cf077f772
Sample build is here: https://gist.github.com/csrwng/8a2b9fa5e2a67ad65b3b
|
@yin doesn't need to be part of your existing PR, but make a note to come back and revisit this after adding the From references because i think it affects some of this code. |
| @@ -0,0 +1,12 @@ | |||
| angular.module('openshiftConsole') | |||
| // This triggers when an element has either a toggle or data-toggle attribute set on it | |||
jwforres
force-pushed
the
build_config_details
branch
from
72244c9 to
e672e6d
Compare
|
Updated based on review feedback. Updated screenshots. |
jwforres
force-pushed
the
build_config_details
branch
from
e672e6d to
31b1ae3
Compare
jwforres
force-pushed
the
build_config_details
branch
from
31b1ae3 to
61c974a
Compare
|
and now with builds under the same build config being sorted by date (most recent first) |
| return { | ||
| restrict: 'A', | ||
| link: function($scope, element, attrs) { | ||
| $(element).focus(function () { |
There was a problem hiding this comment.
double check in different browsers to make sure this works on keyboard focus and on click. might need to listen for both
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1037/) (Image: devenv-fedora_891) |
|
Evaluated for origin up to 61c974a |
Merged by openshift-bot
No description provided.