-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixtures to test edge cases in the web console #1031
Add fixtures to test edge cases in the web console #1031
Conversation
@@ -0,0 +1,28 @@ | |||
{ | |||
"kind": "List", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this right? I would have expected PodList
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah its a generic list of things, each item specifies its type. I ran all of these with osc create -f whatever.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure these get tested by examples_test.go
----- Original Message -----
@@ -0,0 +1,28 @@
+{
- "kind": "List",
yeah its a generic list of things, each item specifies its type. I ran all
of these withosc create -f whatever.json
Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1031/files#r24759855
Since the overview page wires up lots of interrelated objects, seems like we should set up groups of related fixtures (pods, replication controllers, services, builds, etc), with a way to select an entire group at a time. |
I don't think these are asset specific - can you move them to |
fce8c76
to
d89baf4
Compare
Moved |
LGTM [merge] |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/933/) (Image: devenv-fedora_808) |
Evaluated for origin up to d89baf4 |
Merged by openshift-bot
No description provided.