Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixtures to test edge cases in the web console #1031

Merged
merged 1 commit into from
Feb 17, 2015

Conversation

jwforres
Copy link
Member

No description provided.

@jwforres
Copy link
Member Author

@smarterclayton

@@ -0,0 +1,28 @@
{
"kind": "List",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right? I would have expected PodList

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah its a generic list of things, each item specifies its type. I ran all of these with osc create -f whatever.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure these get tested by examples_test.go

----- Original Message -----

@@ -0,0 +1,28 @@
+{

  • "kind": "List",

yeah its a generic list of things, each item specifies its type. I ran all
of these with osc create -f whatever.json


Reply to this email directly or view it on GitHub:
https://github.com/openshift/origin/pull/1031/files#r24759855

@liggitt
Copy link
Contributor

liggitt commented Feb 16, 2015

Since the overview page wires up lots of interrelated objects, seems like we should set up groups of related fixtures (pods, replication controllers, services, builds, etc), with a way to select an entire group at a time.

@smarterclayton
Copy link
Contributor

I don't think these are asset specific - can you move them to test/fixtures/app-scenarios or similar?

@jwforres jwforres force-pushed the add_fixtures_edge_cases branch from fce8c76 to d89baf4 Compare February 16, 2015 16:20
@jwforres
Copy link
Member Author

Moved

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/933/) (Image: devenv-fedora_808)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to d89baf4

openshift-bot pushed a commit that referenced this pull request Feb 17, 2015
@openshift-bot openshift-bot merged commit da0a628 into openshift:master Feb 17, 2015
@jwforres jwforres deleted the add_fixtures_edge_cases branch March 19, 2015 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants