Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ActiveDeadlineSeconds in deployer hook pods correctly #11352

Closed
0xmichalis opened this issue Oct 13, 2016 · 0 comments
Closed

Set ActiveDeadlineSeconds in deployer hook pods correctly #11352

0xmichalis opened this issue Oct 13, 2016 · 0 comments
Assignees
@mfojtik
Labels
component/apps kind/bug Categorizes issue or PR as related to a bug. priority/P2

Comments

@0xmichalis
Copy link
Contributor

Currently we set the default activeDeadlineSeconds[1] used by the deployer pod in every hook pod. Instead hook pods active deadline should be:

defaultActiveDeadlineSeconds - (currentTime - mainDeployerCreationTime)

[1]

origin/pkg/deploy/api/types.go

Line 263 in bc0a4dc

const MaxDeploymentDurationSeconds int64 = 21600

cc: @mfojtik @smarterclayton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfojtik mfojtik

Labels
component/apps kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfojtik @0xmichalis