Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSDOCS12516] OSD-GCP-Document specific commands that list clusters that are using WIF #84336

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[OSDOCS12516] OSD-GCP-Document specific commands that list clusters that are using WIF #84336

merged 1 commit into from
Nov 18, 2024

Conversation

mletalie
Copy link
Contributor

@mletalie mletalie commented Oct 31, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2024
@mletalie mletalie changed the title Osdocs 12516 [OSDOCS12516] OSD-GCP-Document specific commands that list clusters that are using WIF Oct 31, 2024
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 31, 2024 •
edited
Loading

🤖 Thu Nov 14 20:36:48 - Prow CI generated the docs preview:

https://84336--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_install_access_delete_cluster/creating-a-gcp-cluster-with-workload-identity-federation.html

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
@mletalie mletalie force-pushed the OSDOCS-12516 branch 2 times, most recently from e74fdb4 to 0ef32ac Compare November 14, 2024 19:54
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 14, 2024

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patriksuba
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@AedinC
Copy link
Contributor

AedinC commented Nov 18, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 18, 2024
AedinC
AedinC reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@AedinC AedinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

modules/create-wif-cluster-cli.adoc
$ ocm list clusters --parameter search="gcp.authentication.wif_config_id != ''"
----
To list all of your {product-title} clusters that have been deployed using a specific wif-config, run the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To list all of your {product-title} clusters that have been deployed using a specific wif-config, run the following command:
To list all of your {product-title} clusters that have been deployed using a specific `wif-config`, run the following command:

@AedinC
Copy link
Contributor

AedinC commented Nov 18, 2024

/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 18, 2024
@mletalie
Copy link
Contributor Author

/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 18, 2024
@EricPonvelle EricPonvelle merged commit 67a6b26 into openshift:main Nov 18, 2024
2 checks passed
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.17

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

@EricPonvelle: new pull request created: #85068

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@EricPonvelle: new pull request created: #85069

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Nov 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AedinC AedinC AedinC left review comments

Assignees

@AedinC AedinC

@patriksuba patriksuba

Labels
branch/enterprise-4.17 branch/enterprise-4.18 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mletalie @ocpdocs-previewbot @patriksuba @AedinC @EricPonvelle @openshift-cherrypick-robot