-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Revert E2E test change which validates the CVO Image propagation #5323
NO-JIRA: Revert E2E test change which validates the CVO Image propagation #5323
Conversation
Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@jparrill: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jparrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: hypershift |
This is reverting a small change done in #5168 in order to fix the Upgrade tests on E2E.
hostedCluster.Status.Version
is mirrored up from the CVO and doesn't propagate immediately, so we need to verify the image we pass toWaitForImageRollout
is present in the status before we check any other thing.https://github.com/openshift/hypershift/pull/5168/files#diff-cebde6b83b4b372162b2c6a22710a4ab0b1838576120535593a66a3a9bdfc170