Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNTRLPLANE-26: Disable building HO for s390x platform on PR #5314

Merged
merged 1 commit into from
Dec 19, 2024
Merged

CNTRLPLANE-26: Disable building HO for s390x platform on PR #5314

merged 1 commit into from
Dec 19, 2024

Conversation

devguyio
Copy link
Contributor

@devguyio devguyio commented Dec 18, 2024 •
edited
Loading

What this PR does / why we need it:
Due to capacity issues in s390x environment, we're instructed to stop building images on PR for s390x

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

@devguyio: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
Due to capacity issues in s390x environment, we're instructed to stop building images on push for s390x

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2024
@devguyio
Copy link
Contributor Author

/area ci-tooling

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Dec 18, 2024
@devguyio devguyio changed the title NO-JIRA: Disable building HO for s390x platform on push NO-JIRA: Disable building HO for s390x platform on PR Dec 18, 2024
bryan-cox
bryan-cox reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add the why/description to the commit message?

.tekton/hypershift-operator-main-pull-request.yaml
@@ -206,34 +206,6 @@ spec:
workspace: workspace-arm64
- name: basic-auth
workspace: git-auth
- name: clone-repository-s390x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just comment everything out rather than removing it? That way we can just uncomment it back in once s390x is supported again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I'm not a big fan of commenting out code. Git history is always there and one can see whatever was removed. But sure, if that's what folks want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed, a JIRA issue is now referenced

@devguyio
Copy link
Contributor Author

devguyio commented Dec 19, 2024 •
edited by openshift-ci bot
Loading

/retitle "CNTRLPLANE-26: Disable building HO for s390x platform on PR"

@openshift-ci openshift-ci bot changed the title NO-JIRA: Disable building HO for s390x platform on PR "CNTRLPLANE-26: Disable building HO for s390x platform on PR" Dec 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024 •
edited by openshift-ci bot
Loading

@devguyio: This pull request references CNTRLPLANE-26 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
Due to capacity issues in s390x environment, we're instructed to stop building images on PR for s390x

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@devguyio
Disable building HO for s390x platform on PR
6a13b42 
Due to environment capacity issues, we're instructed to disable
konflux pipeline tasks for s390x platfrom.

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@devguyio
Copy link
Contributor Author

Would you please add the why/description to the commit message?

Done

@jparrill
Copy link
Contributor

/approve

@devguyio
Copy link
Contributor Author

/retitle [CNTRLPLANE-26: Disable building HO for s390x platform on PR

@openshift-ci openshift-ci bot changed the title "CNTRLPLANE-26: Disable building HO for s390x platform on PR" [CNTRLPLANE-26: Disable building HO for s390x platform on PR Dec 19, 2024
@devguyio
Copy link
Contributor Author

devguyio commented Dec 19, 2024 •
edited by openshift-ci bot
Loading

/retitle CNTRLPLANE-26: Disable building HO for s390x platform on PR

@openshift-ci openshift-ci bot changed the title [CNTRLPLANE-26: Disable building HO for s390x platform on PR CNTRLPLANE-26: Disable building HO for s390x platform on PR Dec 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7b99ad8 into openshift:main Dec 19, 2024
5 of 6 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202412191309.p0.g7b99ad8.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox bryan-cox left review comments

@jparrill jparrill jparrill left review comments

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devguyio @openshift-ci-robot @jparrill @bryan-cox @openshift-bot