Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Only use public IPs for 4.16 and above #5304

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Dec 16, 2024

What this PR does / why we need it:
Currently CAPI is not allowing instances with Public IPs in 4.15 and earlier. For now, this change only enables public IPs for versions 4.16 and newer.

Currently CAPI is not allowing instances with Public IPs in 4.15 and
earlier. For now, this change only enables public IPs for versions 4.16
and newer.
@openshift-ci-robot
Copy link

@csrwng: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:
Currently CAPI is not allowing instances with Public IPs in 4.15 and earlier. For now, this change only enables public IPs for versions 4.16 and newer.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 16, 2024
@openshift-ci openshift-ci bot requested review from hasueki and sjenning December 16, 2024 15:59
@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label Dec 16, 2024
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Dec 16, 2024
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@csrwng
Copy link
Contributor Author

csrwng commented Dec 16, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba6cf38 and 2 for PR HEAD 0a44e45 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba6cf38 and 2 for PR HEAD 0a44e45 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba6cf38 and 2 for PR HEAD 0a44e45 in total

@sjenning
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba6cf38 and 2 for PR HEAD 0a44e45 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ba6cf38 and 2 for PR HEAD 0a44e45 in total

@sjenning
Copy link
Contributor

/override ci/prow/e2e-aws-override

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws-override

In response to this:

/override ci/prow/e2e-aws-override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@csrwng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 0a44e45 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ef8596d into openshift:main Dec 17, 2024
15 of 16 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202412171706.p0.gef8596d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants