HOSTEDCP-2220: Autonode karpenter #5279
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@enxebre: This pull request references HOSTEDCP-2220 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
area/api
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
area/cli
|
/test e2e-aws |
| r.CreateOrUpdateProvider = upsert.New(false) | ||
|
|
||
| // First install the CRDs so we can create a watch below. | ||
| mgr.GetClient() |
There was a problem hiding this comment.
the return value is ignored, is this needed?
There was a problem hiding this comment.
no needed, I dropped it. Thanks!
| return ctrl.Result{}, err | ||
| } | ||
|
|
||
| if err := r.reconcileKarpenter(ctx, hcp); err != nil { |
There was a problem hiding this comment.
I can't find the implementation of this function anywhere in the PR :)
There was a problem hiding this comment.
enxebre
force-pushed
the
autonode-karpenter
branch
2 times, most recently
from
a93a1b2 to
d5e0084
Compare
|
/lgtm |
This introduces a selfcontained controller that knows how to run karpenter management side watching a guest cluster and managing karpeneter CRDs
enxebre
force-pushed
the
autonode-karpenter
branch
from
d5e0084 to
2ea0ca0
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
The Karpeneter Operator Deployment is fully OCP version agnostic, it's applied by the HO and the binary lives within the HO image
enxebre
force-pushed
the
autonode-karpenter
branch
from
2ea0ca0 to
f596b35
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
|
/override "Red Hat Konflux / hypershift-operator-main-on-pull-request" |
|
@enxebre: Overrode contexts on behalf of enxebre: Red Hat Konflux / hypershift-operator-main-on-pull-request In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override e2e-aks |
|
@enxebre: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aks |
|
@enxebre: Overrode contexts on behalf of enxebre: ci/prow/e2e-aks In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 59e208a
into
openshift:main
|
@enxebre: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: hypershift |
What this PR does / why we need it:
This introduces support for an autoNode feature via karpenter:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist