Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: set diskStorageAccountType in aks e2e #5273

Merged
merged 1 commit into from
Dec 13, 2024
Merged

NO-JIRA: set diskStorageAccountType in aks e2e #5273

merged 1 commit into from
Dec 13, 2024

Conversation

Patryk-Stefanski
Copy link
Contributor

What this PR does / why we need it:

  • setting diskSotrageAccountType so that if the validation on the nodepool for this changes it will be caught in the e2e

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2024
@openshift-ci-robot
Copy link

@Patryk-Stefanski: This pull request explicitly references no jira issue.

In response to this:

What this PR does / why we need it:

  • setting diskSotrageAccountType so that if the validation on the nodepool for this changes it will be caught in the e2e

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Member

/approve

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Dec 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2024
@Patryk-Stefanski Patryk-Stefanski force-pushed the set_diskStorageAccountType_in_aks_e2e branch from 9236be1 to 33d6649 Compare December 11, 2024 21:15
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024
@Patryk-Stefanski Patryk-Stefanski force-pushed the set_diskStorageAccountType_in_aks_e2e branch from 33d6649 to afa3bb8 Compare December 11, 2024 21:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 11, 2024
@Patryk-Stefanski Patryk-Stefanski force-pushed the set_diskStorageAccountType_in_aks_e2e branch from afa3bb8 to 9e73303 Compare December 11, 2024 21:18
@Patryk-Stefanski
NO-JIRA: set diskStorageAccountType in aks e2e
cd87174 
setting diskSotrageAccountType so that if the kube validation on the nodepool crd for this changes it will be caught in the e2e
@Patryk-Stefanski Patryk-Stefanski force-pushed the set_diskStorageAccountType_in_aks_e2e branch from 9e73303 to cd87174 Compare December 12, 2024 01:54
@bryan-cox
Copy link
Member

/test e2e-aks

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

@Patryk-Stefanski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn cd87174 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0363955 into openshift:main Dec 13, 2024
11 of 12 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202412131806.p0.g0363955.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@jparrill jparrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Patryk-Stefanski @openshift-ci-robot @bryan-cox @jparrill @openshift-bot @openshift-merge-robot