Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-42338: Update KCM node monitor grace period #5166

Merged
merged 1 commit into from
Dec 7, 2024
Merged

OCPBUGS-42338: Update KCM node monitor grace period #5166

merged 1 commit into from
Dec 7, 2024

Conversation

jonesbr17
Copy link
Contributor

What this PR does / why we need it:
Follow-up to #4786

The Kubernetes controller manager default for node monitor grace period is not sufficient to avoid node readiness flaps during brief connectivity problems. Change is restricted to IBMCloud only.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #https://issues.redhat.com/browse/OCPBUGS-42338

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@jonesbr17
OCPBUGS-42338: Update KCM node monitor grace period
b7f6418 
Follow-up to openshift#4786

The Kubernetes controller manager default for node monitor grace period
is not sufficient to avoid node readiness flaps during brief connectivity
problems. Change is restricted to IBMCloud only.
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 20, 2024
@openshift-ci-robot
Copy link

@jonesbr17: This pull request references Jira Issue OCPBUGS-42338, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Follow-up to #4786

The Kubernetes controller manager default for node monitor grace period is not sufficient to avoid node readiness flaps during brief connectivity problems. Change is restricted to IBMCloud only.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #https://issues.redhat.com/browse/OCPBUGS-42338

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and hasueki November 20, 2024 21:51
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Nov 20, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit b7f6418
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/673e5970d8b937000858fadf
😎 Deploy Preview https://deploy-preview-5166--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rtheis
rtheis approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rtheis
Copy link
Contributor

rtheis commented Nov 21, 2024

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@jonesbr17
Copy link
Contributor Author

/retest-required

2 similar comments
@rtheis
Copy link
Contributor

rtheis commented Nov 22, 2024

/retest-required

@jonesbr17
Copy link
Contributor Author

/retest-required

@rtheis
Copy link
Contributor

rtheis commented Nov 26, 2024

/test okd-scos-e2e-aws-ovn

@sjenning
Copy link
Contributor

sjenning commented Dec 4, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonesbr17, rtheis, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 857ccab and 2 for PR HEAD b7f6418 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 443bf28 and 1 for PR HEAD b7f6418 in total

@rtheis
Copy link
Contributor

rtheis commented Dec 5, 2024

/retest-required

3 similar comments
@rtheis
Copy link
Contributor

rtheis commented Dec 5, 2024

/retest-required

@rtheis
Copy link
Contributor

rtheis commented Dec 5, 2024

/retest-required

@rtheis
Copy link
Contributor

rtheis commented Dec 5, 2024

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 98a9e48 and 0 for PR HEAD b7f6418 in total

@rtheis
Copy link
Contributor

rtheis commented Dec 5, 2024

/retest-required

@rtheis
Copy link
Contributor

rtheis commented Dec 5, 2024

/retest-required

@rtheis
Copy link
Contributor

rtheis commented Dec 5, 2024

retest-required

@rtheis
Copy link
Contributor

rtheis commented Dec 5, 2024

/retest-required

1 similar comment
@rtheis
Copy link
Contributor

rtheis commented Dec 6, 2024

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 913d7e6 and 2 for PR HEAD b7f6418 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 913d7e6 and 2 for PR HEAD b7f6418 in total

@rtheis
Copy link
Contributor

rtheis commented Dec 6, 2024

/test e2e-kubevirt-aws-ovn-reduced

@rtheis
Copy link
Contributor

rtheis commented Dec 6, 2024

@jonesbr17 please ask Red Hat for assistance since I be that we need them to override this failure.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 913d7e6 and 2 for PR HEAD b7f6418 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 913d7e6 and 2 for PR HEAD b7f6418 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0c67adf and 1 for PR HEAD b7f6418 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 477d939 and 0 for PR HEAD b7f6418 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 477d939 and 2 for PR HEAD b7f6418 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1b8499a and 1 for PR HEAD b7f6418 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 7, 2024

@jonesbr17: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9c85495 into openshift:main Dec 7, 2024
16 checks passed
@openshift-ci-robot
Copy link

@jonesbr17: Jira Issue OCPBUGS-42338: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42338 has been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Follow-up to #4786

The Kubernetes controller manager default for node monitor grace period is not sufficient to avoid node readiness flaps during brief connectivity problems. Change is restricted to IBMCloud only.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #https://issues.redhat.com/browse/OCPBUGS-42338

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rtheis
Copy link
Contributor

rtheis commented Dec 7, 2024

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link

@rtheis: new pull request created: #5250

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 7, 2024
Merged
@jonesbr17 jonesbr17 deleted the grace-period-ibm-cloud branch December 9, 2024 13:22
@muraee muraee mentioned this pull request Dec 16, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtheis rtheis rtheis approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@hasueki hasueki Awaiting requested review from hasueki

Assignees

@rtheis rtheis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonesbr17 @openshift-ci-robot @rtheis @sjenning @openshift-cherrypick-robot