Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1850: HyperShift operator: Allow setting Kube APIServer maximum requests inflight #4554

Merged
merged 1 commit into from
Sep 5, 2024
Merged

HOSTEDCP-1850: HyperShift operator: Allow setting Kube APIServer maximum requests inflight #4554

merged 1 commit into from
Sep 5, 2024

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Aug 13, 2024

What this PR does / why we need it:
Adds support to the HyperShift operator for overriding default maximum requests in flight for Kubernetes API server.
Adds fields to the ClusterSizingConfiguration CRD that allows setting values for these based on cluster size.

This is the hypershift operator half of #4488

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1850

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2024 •
edited by openshift-ci bot
Loading

@csrwng: This pull request references HOSTEDCP-1850 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:
Adds support to the HyperShift operator for overriding default maximum requests in flight for Kubernetes API server.
Adds fields to the ClusterSizingConfiguration CRD that allows setting values for these based on cluster size.

This is the hypershift operator half of #4488

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1850

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Aug 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Aug 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 14, 2024 •
edited
Loading

@csrwng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 2cf6f82 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jparrill
jparrill reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question, otherwise lgtm

hypershift-operator/controllers/scheduler/dedicated_request_serving_nodes.go
@@ -771,6 +771,12 @@ func (r *DedicatedServingComponentSchedulerAndSizer) updateHostedCluster(ctx con
delete(hc.Annotations, hyperv1.MachineHealthCheckTimeoutAnnotation)
}
}
if sizeConfig.Effects != nil && sizeConfig.Effects.MaximumRequestsInflight != nil {
hc.Annotations[hyperv1.KubeAPIServerMaximumRequestsInFlight] = fmt.Sprint(*sizeConfig.Effects.MaximumRequestsInflight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there any kind of validation around the annotation content?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CR ensures that it is a number. As far as limiting the values for that number, I'm not sure that we know just yet what those limits should be. This is an API that is meant to be consumed by the service provider (ie. fleet manager), so I'm less worried about validation here.

@csrwng
HyperShift operator: Allow setting Kube APIServer maximum requests in…
1f621de 
… flight

Adds support to the HyperShift operator for overriding default maximum
requests in flight for Kubernetes API server.
Adds fields to the ClusterSizingConfiguration CRD that allows setting
values for these based on cluster size.
@csrwng csrwng force-pushed the ho_requests_in_flight branch from 2cf6f82 to 1f621de Compare September 5, 2024 13:25
@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Sep 5, 2024
@jparrill
Copy link
Contributor

jparrill commented Sep 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d9b0806 and 2 for PR HEAD 1f621de in total

@openshift-merge-bot openshift-merge-bot bot merged commit a06023a into openshift:main Sep 5, 2024
13 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202409052113.p0.ga06023a.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparrill jparrill jparrill left review comments

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@jparrill jparrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csrwng @openshift-ci-robot @jparrill @openshift-bot