HOSTEDCP-1716: When running the HO locally it should no required a running pod #4268
Conversation
|
@marcbrown2024: This pull request references HOSTEDCP-1716 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
area/documentation
|
Hi @marcbrown2024. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@marcbrown2024: This pull request references HOSTEDCP-1716 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@marcbrown2024: This pull request references HOSTEDCP-1716 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@marcbrown2024 thanks for the contributions! I would suggest a slightly different track:
In |
|
@stevekuznetsov I think we need both, since they're for different scenarios. Running the hypershift operator locally while pointing to a fully deployed management cluster (on AWS or Azure) allows you to test/debug things that you would only see in an environment like that (say nodepool controller AWS specifics, or even the scheduler/scaler for ROSA). The integration environment lets you quickly validate other things, and is definitely useful, so we should also document it. |
|
@csrwng the integration scripts have no requirements on what they are pointed at - why not use them to hot-replace the |
|
I guess I'd just say - let's put some value on executable, re-usable functionality here. I think everyone doing development on HyperShift has their own assemblage of shell scripts, hack docs, whatever. It's a lot. Find some semi-reusable thing and eat the cost of it not being perfectly optimal for your specific/special use-case, and reap the benefits to collaboration and onboarding of having a common platform. |
marcbrown2024
force-pushed
the
hypershift-operator-locally
branch
from
ec521be to
8d588a8
Compare
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
openshift-ci
bot
added
the
area/ci-tooling
marcbrown2024
force-pushed
the
hypershift-operator-locally
branch
from
8d588a8 to
d461491
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, marcbrown2024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
hack/dev/hypershft-install.sh
Outdated
| BUCKET_NAME="${HYPERSHIFT_BUCKET_NAME:-hypershift-ci-oidc}" | ||
| AWSCREDS="${HYPERSHIFT_AWS_CREDS:-$HOME/.aws/credentials}" | ||
|
|
||
| # Install hypershift |
There was a problem hiding this comment.
do we want to setup external dns https://hypershift-docs.netlify.app/how-to/aws/external-dns/
hypershift install --external-dns-provider=aws --external-dns-credentials=route53-aws-creds --external-dns-domain-filter=service-provider-domain.com ...?
There was a problem hiding this comment.
that would definitely be useful for AWS, but not for AKS. Should we have different scripts for the different environments where we may want to install? (we could start by renaming this one with -aws) and install external-dns, wdyt?
There was a problem hiding this comment.
One entrypoint that everyone uses, which knows how to validate the expected input based on the target you're deploying to? :D
There was a problem hiding this comment.
fwiw we do use external DNS atm in aks as well. But yes let's have a way to install the opinions per platform.
marcbrown2024
force-pushed
the
hypershift-operator-locally
branch
from
d461491 to
4c9ee48
Compare
Makefile
Outdated
| @@ -286,3 +290,11 @@ ci-install-hypershift-private: | |||
| regenerate-pki: | |||
| REGENERATE_PKI=1 $(GO) test ./control-plane-pki-operator/... | |||
| REGENERATE_PKI=1 $(GO) test ./test/e2e/... -run TestRegeneratePKI | |||
|
|
|||
| .PHONY: hypershift-install-aws | |||
| hypershift-install-aws: | |||
There was a problem hiding this comment.
Are you saying I should rename it to hypershift-install-aws-dev?
| 4. Install HyperShift in development mode which causes the operator deployment to be deployment scaled to zero so that it doesn't conflict with your local operator process (see [Prerequisites](../getting-started.md#prerequisites)): | ||
|
|
||
| ```shell linenums="1" | ||
| HYPERSHIFT_REGION=us-east-2 HYPERSHIFT_BUCKET_NAME=my-bucket make hypershift-install-aws |
There was a problem hiding this comment.
why do I need to export the variables and then pass them again?
There was a problem hiding this comment.
Also can we mention you can set them but there's defaults and make whatever should just work without exporting or setting anything
There was a problem hiding this comment.
You are exporting the vars because in the script the default is us-east-1 and bucket is hypershift-ci-oidc. So you'll have to export the correct var if default is not what is needed
should no required a running pod This PR covers the steps to run the HyperShift Operator locally without needing access to a full production environment. Fixes #HOSTEDCP-1716
marcbrown2024
force-pushed
the
hypershift-operator-locally
branch
from
4c9ee48 to
cc1aa3c
Compare
|
/retest |
| --oidc-storage-provider-s3-credentials "${AWSCREDS}" \ | ||
| --oidc-storage-provider-s3-region "${REGION}" \ | ||
| --oidc-storage-provider-s3-bucket-name "${BUCKET_NAME}" \ | ||
| --control-plane-operator-image=quay.io/hypershift/hypershift:latest |
There was a problem hiding this comment.
probably worth making --control-plane-operator-image a variable
|
/lgtm |
|
@marcbrown2024: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This PR covers the steps to run the HyperShift Operator locally without needing access to a full production environment.
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-1716
Checklist