Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1684: remove CLI requirement for RG flag when NSG ID is supp… #4232

Merged
merged 1 commit into from
Jun 21, 2024
Merged

HOSTEDCP-1684: remove CLI requirement for RG flag when NSG ID is supp… #4232

merged 1 commit into from
Jun 21, 2024

Conversation

Patryk-Stefanski
Copy link
Contributor

What this PR does / why we need it: removes CLI requirement for RG flag when NSG ID is supplied

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # HOSTEDCP-1684

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 17, 2024 •
edited by openshift-ci bot
Loading

@Patryk-Stefanski: This pull request references HOSTEDCP-1684 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

What this PR does / why we need it: removes CLI requirement for RG flag when NSG ID is supplied

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes # HOSTEDCP-1684

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@netlify Netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit f692776
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/667433533b6b4b000801266d
😎 Deploy Preview https://deploy-preview-4232--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI and removed do-not-merge/needs-area labels Jun 17, 2024
@bryan-cox
Copy link
Member

/retest

2 similar comments
@Patryk-Stefanski
Copy link
Contributor Author

/retest

@Patryk-Stefanski
Copy link
Contributor Author

/retest

@jparrill
Copy link
Contributor

/retest-required

@jparrill
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
@Patryk-Stefanski
Copy link
Contributor Author

/test all

@Patryk-Stefanski
Copy link
Contributor Author

/test e2e-azure

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

@Patryk-Stefanski: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9ad2b2a into openshift:main Jun 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Patryk-Stefanski @openshift-ci-robot @bryan-cox @jparrill