HOSTEDCP-1709: hack/test: remove timeouts #4169
Conversation
The top-level `go test` timeout does nothing beneficial for us - we need to be well-formed in the face of SIGTERM from the test platform anyway, and we need to time out within our tests, not from the top-level, as this will give us sensible test failure output (e.g. a specific assertion failed) versus the current panic output which makes it impossible to generate jUnit. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
|
@stevekuznetsov: This pull request references HOSTEDCP-1709 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
/area testing |
openshift-ci
bot
added
area/testing
openshift-ci
bot
added
the
area/ci-tooling
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
/retest |
|
@stevekuznetsov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 2072710
into
openshift:main
The top-level
go testtimeout does nothing beneficial for us - we need to be well-formed in the face of SIGTERM from the test platform anyway, and we need to time out within our tests, not from the top-level, as this will give us sensible test failure output (e.g. a specific assertion failed) versus the current panic output which makes it impossible to generate jUnit./assign @sjenning