Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1456: Revert #3448 "api: move CSRA to a new group" #3460

Merged
merged 1 commit into from
Jan 24, 2024
Merged

TRT-1456: Revert #3448 "api: move CSRA to a new group" #3460

merged 1 commit into from
Jan 24, 2024

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Jan 24, 2024 •
edited by openshift-ci bot
Loading

Reverts #3448 ; tracked by TRT-1456

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

4.16 CI payload jobs are failing

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

TBD

CC: @stevekuznetsov

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift#3448 from stevekuznetsov/skuznet…
f061078 
…s/rename-cert-gv"

This reverts commit 6c84753, reversing
changes made to 9b08dcf.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 24, 2024 •
edited by openshift-ci bot
Loading

@stbenjam: This pull request references TRT-1456 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #3448 ; tracked by TRT-1456

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

4.16 CI payload jobs are failing

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

TBD

CC: @stevekuznetsov

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 24, 2024 •
edited by openshift-ci bot
Loading

@stbenjam: This pull request references TRT-1456 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts #3448 ; tracked by TRT-1456

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

4.16 CI payload jobs are failing

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

TBD

CC: @stevekuznetsov

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stbenjam stbenjam changed the title TRT-1456: Revert #3448 "HOSTEDCP-1344: api: move CSRA to a new group" TRT-1456: Revert #3448 "api: move CSRA to a new group" Jan 24, 2024
@csrwng
Copy link
Contributor

csrwng commented Jan 24, 2024

/approve
/lgtm

@netlify Netlify
Copy link

netlify bot commented Jan 24, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit f061078
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65b12147cb969900085901db
😎 Deploy Preview https://deploy-preview-3460--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stbenjam
Copy link
Member Author

/area hypershift-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@stbenjam: Can not set label area/hypershift-operator: Must be member in one of these teams: []

In response to this:

/area hypershift-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI labels Jan 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release lgtm Indicates that a PR is ready to be merged. area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Jan 24, 2024
@sjenning
Copy link
Contributor

/override e2e-kubevirt-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@sjenning: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-kubevirt-aws-ovn

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws
  • ci/prow/e2e-ibmcloud-iks
  • ci/prow/e2e-ibmcloud-roks
  • ci/prow/e2e-kubevirt-aws-ovn
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • netlify/hypershift-docs/deploy-preview
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-iks
  • pull-ci-openshift-hypershift-main-e2e-ibmcloud-roks
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor

/override ci/prow/e2e-kubevirt-aws-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-kubevirt-aws-ovn

In response to this:

/override ci/prow/e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d7b8d75 into openshift:main Jan 24, 2024
12 of 14 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks f061078 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks f061078 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

stevekuznetsov added a commit to stevekuznetsov/hypershift that referenced this pull request Jan 24, 2024
@stevekuznetsov
Revert "Merge pull request openshift#3460 from stbenjam/revert-3448-1…
1e1fef7 
…706107197301"

This reverts commit d7b8d75, reversing
changes made to 6c84753.
@stevekuznetsov stevekuznetsov mentioned this pull request Jan 24, 2024
Merged
stevekuznetsov added a commit to stevekuznetsov/hypershift that referenced this pull request Jan 29, 2024
@stevekuznetsov
Revert "Merge pull request openshift#3460 from stbenjam/revert-3448-1…
40530b8 
…706107197301"

This reverts commit d7b8d75, reversing
changes made to 6c84753.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
This was referenced Jan 29, 2024
Closed
Merged
@stevekuznetsov stevekuznetsov mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stbenjam @openshift-ci-robot @csrwng @sjenning