Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1344: api: move CSRA to a new group #3448

Merged
merged 1 commit into from
Jan 24, 2024
Merged

HOSTEDCP-1344: api: move CSRA to a new group #3448

merged 1 commit into from
Jan 24, 2024

Conversation

stevekuznetsov
Copy link
Contributor

We can't get a more natural directory structure for this new group using the generators as they are - but we do get the correct API paths, etc, so it seems like we should deal with the structure for now and fix it when or if upstream decides to support nested groups.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@netlify Netlify
Copy link

netlify bot commented Jan 22, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit cde9a8f
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65ae921d2d154b0008ac4eba
😎 Deploy Preview https://deploy-preview-3448--hypershift-docs.netlify.app/reference/api
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@csrwng
Copy link
Contributor

csrwng commented Jan 22, 2024

/area hypershift-operator

@csrwng
Copy link
Contributor

csrwng commented Jan 22, 2024

/approve

@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels Jan 22, 2024
@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release labels Jan 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Indicates the PR includes changes for e2e testing labels Jan 22, 2024
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@stevekuznetsov stevekuznetsov force-pushed the skuznets/rename-cert-gv branch from cde9a8f to 6aa1802 Compare January 22, 2024 18:21
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed lgtm Indicates that a PR is ready to be merged. labels Jan 22, 2024
@stevekuznetsov
api: move CSRA to a new group
281ec93 
We can't get a more natural directory structure for this new group using
the generators as they are - but we *do* get the correct API paths, etc,
so it seems like we should deal with the structure for now and fix it
when or if upstream decides to support nested groups.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/rename-cert-gv branch from 6aa1802 to 281ec93 Compare January 22, 2024 19:50
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@stevekuznetsov stevekuznetsov changed the title api: move CSRA to a new group HOSTEDCP-1344: api: move CSRA to a new group Jan 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2024 •
edited by openshift-ci bot
Loading

@stevekuznetsov: This pull request references HOSTEDCP-1344 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

We can't get a more natural directory structure for this new group using the generators as they are - but we do get the correct API paths, etc, so it seems like we should deal with the structure for now and fix it when or if upstream decides to support nested groups.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9b08dcf and 2 for PR HEAD 281ec93 in total

@stevekuznetsov
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@stevekuznetsov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 281ec93 link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks 281ec93 link false /test e2e-ibmcloud-iks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6c84753 into openshift:main Jan 24, 2024
12 of 14 checks passed
@stbenjam stbenjam mentioned this pull request Jan 24, 2024
Merged
stbenjam added a commit to stbenjam/hypershift that referenced this pull request Jan 24, 2024
@stbenjam
Revert "Merge pull request openshift#3448 from stevekuznetsov/skuznet…
f061078 
…s/rename-cert-gv"

This reverts commit 6c84753, reversing
changes made to 9b08dcf.
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202401241315.p0.g6c84753.assembly.stream for distgit hypershift.
All builds following this will include this PR.

openshift-merge-bot bot added a commit that referenced this pull request Jan 24, 2024
@openshift-merge-bot
Merge pull request #3460 from stbenjam/revert-3448-1706107197301
d7b8d75 
TRT-1456: Revert #3448 "api: move CSRA to a new group"
stevekuznetsov pushed a commit to stevekuznetsov/hypershift that referenced this pull request Jan 29, 2024
@stbenjam @stevekuznetsov
Revert "Merge pull request openshift#3448 from stevekuznetsov/skuznet…
b6b18f8 
…s/rename-cert-gv"

This reverts commit 6c84753, reversing
changes made to 9b08dcf.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
This was referenced Jan 29, 2024
Closed
Merged
@stevekuznetsov stevekuznetsov mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/control-plane-pki-operator Indicates the PR includes changes for the control plane PKI operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevekuznetsov @csrwng @sjenning @openshift-ci-robot @openshift-bot