Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: Fix issue with release note tool #3429

Merged
merged 1 commit into from
Feb 6, 2024
Merged

NO-JIRA: Fix issue with release note tool #3429

merged 1 commit into from
Feb 6, 2024

Conversation

imain
Copy link
Contributor

@imain imain commented Jan 16, 2024 •
edited
Loading

Add a more clear error message and return on error in release note tool. Also add support for an authorization token so we can avoid 403 errors.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from csrwng and sjenning January 16, 2024 17:17
@openshift-ci openshift-ci bot added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed do-not-merge/needs-area labels Jan 16, 2024
@bryan-cox
Copy link
Member

The title seems misleading to me unless I'm missing something. This doesn't fix the issue; it just adds additional context on the error message, right?

@imain
Fix issue with release note tool.
40c8f73 
Add support for a token to avoid 403 errors.  Add a more clear error
message and return on error in release note tool.
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2024

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 40c8f73
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/65b030ff893bc50009188856
😎 Deploy Preview https://deploy-preview-3429--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@imain
Copy link
Contributor Author

imain commented Jan 23, 2024

The title seems misleading to me unless I'm missing something. This doesn't fix the issue; it just adds additional context on the error message, right?

Correct! FIxed now :)

bryan-cox
bryan-cox approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@bryan-cox
Copy link
Member

/retitle NO-JIRA: Fix issue with release note tool

@openshift-ci openshift-ci bot changed the title Fix issue with release note tool. NO-JIRA: Fix issue with release note tool Jan 24, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 24, 2024
@openshift-ci-robot
Copy link

@imain: This pull request explicitly references no jira issue.

In response to this:

Add a more clear error message and return on error in release note tool. Also add support for an authorization token so we can avoid 403 errors.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, imain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@bryan-cox
Copy link
Member

/lgtm cancel
someone else should lgtm

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@muraee
Copy link
Contributor

muraee commented Jan 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@imain
Copy link
Contributor Author

imain commented Jan 24, 2024

/test e2e-aws
/test e2e-kubevirt-aws-ovn

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d7b8d75 and 2 for PR HEAD 40c8f73 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8d96c1a and 1 for PR HEAD 40c8f73 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 83fb2da and 0 for PR HEAD 40c8f73 in total

@openshift-ci-robot
Copy link

/hold

Revision 40c8f73 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@bryan-cox
Copy link
Member

/test verify

1 similar comment
@imain
Copy link
Contributor Author

imain commented Feb 5, 2024

/test verify

@bryan-cox
Copy link
Member

/hold cancel
Removing hold that was from tests failing

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@imain: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8b92350 into openshift:main Feb 6, 2024
12 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202402070113.p0.g8b92350.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox bryan-cox approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@muraee muraee

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@imain @bryan-cox @openshift-ci-robot @muraee @openshift-bot