Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23362: Set new condition on SG deletion. #3307

Merged
merged 1 commit into from
Dec 22, 2023
Merged

OCPBUGS-23362: Set new condition on SG deletion. #3307

merged 1 commit into from
Dec 22, 2023

Conversation

jparrill
Copy link
Contributor

@jparrill jparrill commented Dec 12, 2023 •
edited
Loading

Set a new status.condition when CPO deletes the SecurityGroup.

Which issue(s) this PR fixes:
Fixes #OCPBUGS-23362

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2023
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-23362, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Which issue(s) this PR fixes:
Fixes #OCPBUGS-23362

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 12, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Dec 12, 2023
@jparrill jparrill force-pushed the bug/OCPBUGS-23362 branch 2 times, most recently from fbbce87 to f28f0b4 Compare December 13, 2023 16:18
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit ae1787d
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/658468587358fc000814921e
😎 Deploy Preview https://deploy-preview-3307--hypershift-docs.netlify.app/reference/api
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label Dec 13, 2023
@openshift-ci openshift-ci bot added the area/documentation Indicates the PR includes changes for documentation label Dec 18, 2023
@jparrill jparrill marked this pull request as ready for review December 18, 2023 09:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 18, 2023
@jparrill jparrill changed the title OCPBUGS-23362: Set status on SG deletion when AWS returns error OCPBUGS-23362: Set new condition on SG deletion. Dec 18, 2023
@jparrill
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 18, 2023
@openshift-ci-robot
Copy link

@jparrill: This pull request references Jira Issue OCPBUGS-23362, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 18, 2023
bryan-cox
bryan-cox reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but happy to tag if you want to ignore it.

control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go Outdated Show resolved Hide resolved
bryan-cox
bryan-cox approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@jparrill
Copy link
Contributor Author

/retest

@jparrill
Copy link
Contributor Author

/test e2e-kubevirt-aws-ovn

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
bryan-cox
bryan-cox approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
csrwng
csrwng reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@csrwng csrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

api/hypershift/v1beta1/hostedcluster_conditions.go Outdated Show resolved Hide resolved
control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@csrwng
Copy link
Contributor

csrwng commented Dec 21, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
@jparrill
OCPBUGS-23362: Set status on SG deletion when AWS returns error
14fae36 
Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
@csrwng
Copy link
Contributor

csrwng commented Dec 21, 2023

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cc8794f and 2 for PR HEAD 14fae36 in total

@openshift-merge-bot openshift-merge-bot bot merged commit c53a541 into openshift:main Dec 22, 2023
11 of 14 checks passed
@openshift-ci-robot
Copy link

@jparrill: Jira Issue OCPBUGS-23362: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23362 has been moved to the MODIFIED state.

In response to this:

Set a new status.condition when CPO deletes the SecurityGroup.

Which issue(s) this PR fixes:
Fixes #OCPBUGS-23362

Signed-off-by: Juan Manuel Parrilla Madrid jparrill@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 22, 2023

@jparrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 14fae36 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks 14fae36 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jparrill
Copy link
Contributor Author

jparrill commented Jan 8, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot
Copy link

@jparrill: new pull request created: #3381

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng csrwng left review comments

@enxebre enxebre enxebre left review comments

@bryan-cox bryan-cox bryan-cox approved these changes

@hasueki hasueki Awaiting requested review from hasueki

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@csrwng csrwng

@bryan-cox bryan-cox

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jparrill @openshift-ci-robot @csrwng @openshift-cherrypick-robot @enxebre @bryan-cox