HO: Fix haproxy to have apiserver external address for public clusters #1649
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This was accidentally removed in https://github.com/openshift/hypershift/pull/1614/files#diff-8d5b507fe367a80159912e2310bc3e7b76a5aa9dd1f12ccee7a1bf3a9bc2ac49 and breaks public clusters.
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/retest-required |
| @@ -62,6 +65,27 @@ func (r *NodePoolReconciler) reconcileHAProxyIgnitionConfig(ctx context.Context, | |||
| apiServerExternalPort := util.APIPortWithDefaultFromHostedCluster(hcluster, config.DefaultAPIServerPort) | |||
| if util.IsPrivateHC(hcluster) { | |||
| apiServerExternalAddress = fmt.Sprintf("api.%s.hypershift.local", hcluster.Name) | |||
| } else { | |||
There was a problem hiding this comment.
can we have a unit tested getAPIServerExternalAddress that covers this if/else so we don't drop by accident again?
|
@alvaroaleman: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
This was accidentally removed in
https://github.com/openshift/hypershift/pull/1614/files#diff-8d5b507fe367a80159912e2310bc3e7b76a5aa9dd1f12ccee7a1bf3a9bc2ac49
and breaks public clusters.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist