Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop hypershift-operator util and consolidate with support #1647

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Drop hypershift-operator util and consolidate with support #1647

merged 1 commit into from
Aug 4, 2022

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Aug 3, 2022

What this PR does / why we need it:
Following up to #1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from alvaroaleman and csrwng August 3, 2022 17:23
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@enxebre enxebre force-pushed the drop-util branch 2 times, most recently from 44faf52 to dfcaae2 Compare August 3, 2022 18:29
@sjenning
Copy link
Contributor

sjenning commented Aug 3, 2022

staticcheck failure

hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go:61:2: package "github.com/openshift/hypershift/support/util" is being imported more than once (ST1019)
	hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go:62:2: other import of "github.com/openshift/hypershift/support/util"
hypershift-operator/controllers/hostedcluster/hostedcluster_controller.go:3330:6: func reconcileMachineApproverConfig is unused (U1000)
hypershift-operator/controllers/nodepool/nodepool_controller.go:29:2: package "github.com/openshift/hypershift/support/util" is being imported more than once (ST1019)
	hypershift-operator/controllers/nodepool/nodepool_controller.go:30:2: other import of "github.com/openshift/hypershift/support/util"

@netlify
Copy link

netlify bot commented Aug 4, 2022

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 9429b0d
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/62eb799a037ba5000861fe25
😎 Deploy Preview https://deploy-preview-1647--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@enxebre
Drop hypershift-operator util and consolidate with support
250d021 
Following up to openshift#1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

@enxebre: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-kubevirt-gcp-ovn 250d021 link false /test e2e-kubevirt-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 8fdbe5e into openshift:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enxebre @sjenning @alvaroaleman