Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

additional trust bundle into vm #1633

Merged
merged 1 commit into from
Aug 1, 2022
Merged

additional trust bundle into vm #1633

merged 1 commit into from
Aug 1, 2022

Conversation

nadavdolin
Copy link
Contributor

Signed-off-by: nadav dolin nadavdolin1@gmail.com

What this PR does / why we need it:
Fixes #1615

@nadavdolin
additional trust bundle fix
80987d4 
Signed-off-by: nadav dolin <nadavdolin1@gmail.com>
@openshift-ci openshift-ci bot requested review from alvaroaleman and csrwng July 31, 2022 11:38
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2022

Hi @nadavdolin. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Jul 31, 2022

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 80987d4
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/62e669914e86ed000837c79b
😎 Deploy Preview https://deploy-preview-1633--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nadavdolin nadavdolin mentioned this pull request Jul 31, 2022
Closed
@csrwng
Copy link
Contributor

csrwng commented Jul 31, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2022
@nadavdolin
Copy link
Contributor Author

/restart

@nadavdolin
Copy link
Contributor Author

/assign @nadavdolin

@alvaroaleman
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

@nadavdolin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity 80987d4 link false /test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@csrwng
Copy link
Contributor

csrwng commented Aug 1, 2022

/lgtm
/approve
thx!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, nadavdolin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 1d3282c into openshift:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@csrwng csrwng

@nadavdolin nadavdolin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

additional trusted-bundle CA into the vm not work
4 participants
@nadavdolin @csrwng @alvaroaleman @openshift-merge-robot